Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: local policy)
In-Reply-To: <20070824005416.6C1731A9832@eris.apache.org>
References: <20070824005416.6C1731A9832@eris.apache.org>
Mime-Version: 1.0 (Apple Message framework v752.2)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <A28C679B-9310-4234-AAD4-2CB578C1C88B@jaguNET.com>
Cc: cvs@httpd.apache.org
Content-Transfer-Encoding: 7bit
From: Jim Jagielski <jim@jaguNET.com>
Subject: Re: svn commit: r569204 - in /httpd/httpd/trunk/modules/experimental:
 config.m4 mod_rewrite_filter.c mod_sedfilter.c
Date: Fri, 24 Aug 2007 08:28:16 -0400
To: dev@httpd.apache.org


On Aug 23, 2007, at 8:54 PM, wrowe@apache.org wrote:

> Author: wrowe
> Date: Thu Aug 23 17:54:15 2007
> New Revision: 569204
>
> URL: http://svn.apache.org/viewvc?rev=569204&view=rev
> Log:
> SEDFILTER has several anomolies; first, it's not SED syntax,
> but more mod-rewrite like (and using the rewrite pcre parser).
> Secondly, 'FILTER' in the filter name is redundant.  Simplify,
> by renaming this 'REWRITE' filter.
>

IMO, changing this from sedfilter to mod_rewrite_filter
actually is more confusing (or would be) to end users, since
we have a mod_rewrite already. IMO mod_rewrite_content
would be a better choice, esp if mod_rewrite was called
mod_rewrite_url...

In any case, I don't feel strongly enough about it
to do anymore than send this single post...