httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: svn commit: r569204 - in /httpd/httpd/trunk/modules/experimental: config.m4 mod_rewrite_filter.c mod_sedfilter.c
Date Fri, 24 Aug 2007 12:28:16 GMT

On Aug 23, 2007, at 8:54 PM, wrowe@apache.org wrote:

> Author: wrowe
> Date: Thu Aug 23 17:54:15 2007
> New Revision: 569204
>
> URL: http://svn.apache.org/viewvc?rev=569204&view=rev
> Log:
> SEDFILTER has several anomolies; first, it's not SED syntax,
> but more mod-rewrite like (and using the rewrite pcre parser).
> Secondly, 'FILTER' in the filter name is redundant.  Simplify,
> by renaming this 'REWRITE' filter.
>

IMO, changing this from sedfilter to mod_rewrite_filter
actually is more confusing (or would be) to end users, since
we have a mod_rewrite already. IMO mod_rewrite_content
would be a better choice, esp if mod_rewrite was called
mod_rewrite_url...

In any case, I don't feel strongly enough about it
to do anymore than send this single post...


Mime
View raw message