httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wr...@apache.org
Subject svn commit: r569192 - in /httpd/httpd/trunk/modules/aaa: mod_authz_dbd.c mod_authz_dbd.h
Date Fri, 24 Aug 2007 00:08:56 GMT
Author: wrowe
Date: Thu Aug 23 17:08:55 2007
New Revision: 569192

URL: http://svn.apache.org/viewvc?rev=569192&view=rev
Log:
You can't borrow AP_ namespace for imports/exports.

They are specific to one loadable module.

Modified:
    httpd/httpd/trunk/modules/aaa/mod_authz_dbd.c
    httpd/httpd/trunk/modules/aaa/mod_authz_dbd.h

Modified: httpd/httpd/trunk/modules/aaa/mod_authz_dbd.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/aaa/mod_authz_dbd.c?rev=569192&r1=569191&r2=569192&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/aaa/mod_authz_dbd.c (original)
+++ httpd/httpd/trunk/modules/aaa/mod_authz_dbd.c Thu Aug 23 17:08:55 2007
@@ -34,8 +34,12 @@
 /* Export a hook for modules that manage clientside sessions
  * (e.g. mod_auth_cookie)
  * to deal with those when we successfully login/logout at the server
+ *
+ * XXX: WHY would this be specific to dbd_authz?  Why wouldn't we track
+ * this across all authz user providers in a lower level mod, such as 
+ * mod_auth_basic/digest?
  */
-APR_IMPLEMENT_OPTIONAL_HOOK_RUN_ALL(authz_dbd, AP, int, client_login,
+APR_IMPLEMENT_OPTIONAL_HOOK_RUN_ALL(authz_dbd, AUTHZ_DBD, int, client_login,
                             (request_rec *r, int code, const char *action),
                             (r, code, action), OK, DECLINED)
 

Modified: httpd/httpd/trunk/modules/aaa/mod_authz_dbd.h
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/aaa/mod_authz_dbd.h?rev=569192&r1=569191&r2=569192&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/aaa/mod_authz_dbd.h (original)
+++ httpd/httpd/trunk/modules/aaa/mod_authz_dbd.h Thu Aug 23 17:08:55 2007
@@ -18,6 +18,27 @@
 #define MOD_AUTHZ_DBD_H
 #include "httpd.h"
 
-APR_DECLARE_EXTERNAL_HOOK(authz_dbd, AP, int, client_login,
+/* Create a set of AUTHZ_DBD_DECLARE(type), AUTHZ_DBD_DECLARE_NONSTD(type) and 
+ * AUTHZ_DBD_DECLARE_DATA with appropriate export and import tags
+ */
+#if !defined(WIN32)
+#define AUTHZ_DBD_DECLARE(type)            type
+#define AUTHZ_DBD_DECLARE_NONSTD(type)     type
+#define AUTHZ_DBD_DECLARE_DATA
+#elif defined(AUTHZ_DBD_DECLARE_STATIC)
+#define AUTHZ_DBD_DECLARE(type)            type __stdcall
+#define AUTHZ_DBD_DECLARE_NONSTD(type)     type
+#define AUTHZ_DBD_DECLARE_DATA
+#elif defined(AUTHZ_DBD_DECLARE_EXPORT)
+#define AUTHZ_DBD_DECLARE(type)            __declspec(dllexport) type __stdcall
+#define AUTHZ_DBD_DECLARE_NONSTD(type)     __declspec(dllexport) type
+#define AUTHZ_DBD_DECLARE_DATA             __declspec(dllexport)
+#else
+#define AUTHZ_DBD_DECLARE(type)            __declspec(dllimport) type __stdcall
+#define AUTHZ_DBD_DECLARE_NONSTD(type)     __declspec(dllimport) type
+#define AUTHZ_DBD_DECLARE_DATA             __declspec(dllimport)
+#endif
+
+APR_DECLARE_EXTERNAL_HOOK(authz_dbd, AUTHZ_DBD, int, client_login,
                           (request_rec *r, int code, const char *action))
 #endif



Mime
View raw message