httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grega...@apache.org
Subject svn commit: r558039 - /httpd/httpd/trunk/server/mpm/worker/worker.c
Date Fri, 20 Jul 2007 16:20:12 GMT
Author: gregames
Date: Fri Jul 20 09:20:10 2007
New Revision: 558039

URL: http://svn.apache.org/viewvc?view=rev&rev=558039
Log:
the cost of synchronized SMP proof updates far outweighs the value of having
100% accurate MaxRequestsPerChild.  
* it doesn't even count requests, it counts connections.  
* all it is is a number someone pulls out of a hat in an attempt to deal with
  resource leaks.  
i.e., no strong need for accuracy.  

atomic operations are relatively expensive and this is mainline code.

Modified:
    httpd/httpd/trunk/server/mpm/worker/worker.c

Modified: httpd/httpd/trunk/server/mpm/worker/worker.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm/worker/worker.c?view=diff&rev=558039&r1=558038&r2=558039
==============================================================================
--- httpd/httpd/trunk/server/mpm/worker/worker.c (original)
+++ httpd/httpd/trunk/server/mpm/worker/worker.c Fri Jul 20 09:20:10 2007
@@ -892,7 +892,7 @@
         bucket_alloc = apr_bucket_alloc_create(ptrans);
         process_socket(ptrans, csd, process_slot, thread_slot, bucket_alloc);
         worker_sockets[thread_slot] = NULL;
-        requests_this_child--; /* FIXME: should be synchronized - aaron */
+        requests_this_child--; 
         apr_pool_clear(ptrans);
         last_ptrans = ptrans;
     }



Mime
View raw message