httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j..@apache.org
Subject svn commit: r543663 - /httpd/httpd/branches/1.3.x/src/main/http_main.c
Date Fri, 01 Jun 2007 23:36:11 GMT
Author: jim
Date: Fri Jun  1 16:36:11 2007
New Revision: 543663

URL: http://svn.apache.org/viewvc?view=rev&rev=543663
Log:
Some comments... Yes, a 64 char array is overkill, but so
what :) Also, in this section we later on unset as well,
but also encapsulate the logic here as well.

Modified:
    httpd/httpd/branches/1.3.x/src/main/http_main.c

Modified: httpd/httpd/branches/1.3.x/src/main/http_main.c
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/1.3.x/src/main/http_main.c?view=diff&rev=543663&r1=543662&r2=543663
==============================================================================
--- httpd/httpd/branches/1.3.x/src/main/http_main.c (original)
+++ httpd/httpd/branches/1.3.x/src/main/http_main.c Fri Jun  1 16:36:11 2007
@@ -382,8 +382,9 @@
 /*
  * Check the pid table to see if the actual pid exists
  */
+
 static int in_pid_table(int pid) {
-    char apid[64];
+    char apid[64];      /* WAY generous! */
     const char *spid;
     snprintf(apid, sizeof(apid), "%d", pid);
     spid = ap_table_get(pid_table, apid);
@@ -2934,7 +2935,7 @@
                     ap_update_child_status(n, SERVER_DEAD, NULL);
                     /* just mark it as having a successful exit status */
                     bzero((char *) status, sizeof(ap_wait_t));
-                    unset_pid_table(pid);
+                    unset_pid_table(pid);       /* to be safe */
                     return(pid);
                 }
             }



Mime
View raw message