Return-Path: 
 <cvs-return-26627-apmail-httpd-cvs-archive=httpd.apache.org@httpd.apache.org>
Delivered-To: apmail-httpd-cvs-archive@www.apache.org
Received: (qmail 83658 invoked from network); 17 May 2007 23:04:14 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 17 May 2007 23:04:14 -0000
Received: (qmail 21120 invoked by uid 500); 17 May 2007 23:04:20 -0000
Delivered-To: apmail-httpd-cvs-archive@httpd.apache.org
Received: (qmail 21076 invoked by uid 500); 17 May 2007 23:04:20 -0000
Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
list-help: <mailto:cvs-help@httpd.apache.org>
list-unsubscribe: <mailto:cvs-unsubscribe@httpd.apache.org>
List-Post: <mailto:cvs@httpd.apache.org>
List-Id: <cvs.httpd.apache.org>
Delivered-To: mailing list cvs@httpd.apache.org
Received: (qmail 21065 invoked by uid 99); 17 May 2007 23:04:19 -0000
Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 May 2007 16:04:19 -0700
X-ASF-Spam-Status: No, hits=-99.5 required=10.0
	tests=ALL_TRUSTED,NO_REAL_NAME
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 May 2007 16:04:13 -0700
Received: by eris.apache.org (Postfix, from userid 65534)
	id 0B41D1A981D; Thu, 17 May 2007 16:03:53 -0700 (PDT)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r539155 - /httpd/httpd/branches/2.2.x/STATUS
Date: Thu, 17 May 2007 23:03:52 -0000
To: cvs@httpd.apache.org
From: fielding@apache.org
X-Mailer: svnmailer-1.1.0
Message-Id: <20070517230353.0B41D1A981D@eris.apache.org>
X-Virus-Checked: Checked by ClamAV on apache.org

Author: fielding
Date: Thu May 17 16:03:52 2007
New Revision: 539155

URL: http://svn.apache.org/viewvc?view=rev&rev=539155
Log:
8 of 10 on the fugly scale

Modified:
    httpd/httpd/branches/2.2.x/STATUS

Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?view=diff&rev=539155&r1=539154&r2=539155
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Thu May 17 16:03:52 2007
@@ -133,12 +133,20 @@
         http://people.apache.org/~wrowe/mpm_winnt_waits.patch
         is easier to read (-U8)
       +1: mturk
+      +0: fielding (patch is okay, underlying code is crap)
       wrowe notes: a patch should have the necessary effect with the
         minimum lines of code - there's alot of redecorating that's
         going on in this patch to no net effect.  The WAIT_TIMEOUT
         result value seems to be ignored in the revised code?
       mturk notes: WAIT_TIMEOUT is replaced by WAIT_FAILED with
         the accompanied patch in mpm\winnt\child.c.
+      fielding notes: the routine is brain-dead -- one cannot replicate
+        a wait for many objects by iterating through multiple waits with
+        a one second sleep in between loops.  That's insane.
+        The right ways to do that are explained in the MSDN article
+        <http://msdn2.microsoft.com/en-us/library/ms687025.aspx>
+        In any case, it should be checking nCount <= MAXIMUM_WAIT_OBJECTS
+        first and use the simple wait in that case.
 
    * mod_authn_dbd: Export any additional columns queried in the SQL select
      into the environment with the name AUTHENTICATE_<COLUMN>. This brings