httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wr...@apache.org
Subject svn commit: r522944 - /httpd/mod_ftp/trunk/modules/ftp/mod_ftp.c
Date Tue, 27 Mar 2007 15:08:49 GMT
Author: wrowe
Date: Tue Mar 27 08:08:49 2007
New Revision: 522944

URL: http://svn.apache.org/viewvc?view=rev&rev=522944
Log:
Uhm - FTPUMask FTPDirMask are -always- supported (possibly not well, but
that's an apr issue).  FTPUmask happens to be less-lame with fchmod, but
it's not impossible otherwise.  With fchmod, the file perms are 000 as the
file is initally accumulated, and then switched.  Without, the perms are
determined at create-time.

Modified:
    httpd/mod_ftp/trunk/modules/ftp/mod_ftp.c

Modified: httpd/mod_ftp/trunk/modules/ftp/mod_ftp.c
URL: http://svn.apache.org/viewvc/httpd/mod_ftp/trunk/modules/ftp/mod_ftp.c?view=diff&rev=522944&r1=522943&r2=522944
==============================================================================
--- httpd/mod_ftp/trunk/modules/ftp/mod_ftp.c (original)
+++ httpd/mod_ftp/trunk/modules/ftp/mod_ftp.c Tue Mar 27 08:08:49 2007
@@ -428,7 +428,6 @@
 
 static const char *ftp_umask(cmd_parms *cmd, void *dconf, const char *arg)
 {
-#ifdef HAVE_FCHMOD
     int umask, mode;
     char *endp;
     char *error_str = NULL;
@@ -447,15 +446,11 @@
         d->fileperms = ftp_unix_mode2perms(mode);
     }
     return error_str;
-#else
-    return "The FTPUmask directive is not supported on this platform";
-#endif
 }
 
 
 static const char *ftp_dirumask(cmd_parms *cmd, void *dconf, const char *arg)
 {
-#ifdef HAVE_FCHMOD
     int umask, xmask, mode;
     char *endp;
     char *error_str = NULL;
@@ -487,9 +482,6 @@
         d->dirperms = ftp_unix_mode2perms(mode);
     }
     return error_str;
-#else
-    return "The FTPDirUmask directive is not supported on this platform";
-#endif
 }
 
 static const char *ftp_implicit_ssl(cmd_parms *cmd, void *dummy, int arg)



Mime
View raw message