httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wr...@apache.org
Subject svn commit: r495134 - in /httpd/httpd/branches/2.2.x: STATUS srclib/pcre/printint.c
Date Thu, 11 Jan 2007 05:53:11 GMT
Author: wrowe
Date: Wed Jan 10 21:53:09 2007
New Revision: 495134

URL: http://svn.apache.org/viewvc?view=rev&rev=495134
Log:
One more backported (Nick expressed his -1 wasn't ment to be a veto,
next time please state something other than -1.  -.999 would be fine.)

Fix building PCRE with -DDEBUG on just about all the platforms under 
my roof (FreeBSD, Darwin, Ubuntu Breezy)

Submitted by: sctemme
Backports: r381783

Modified:
    httpd/httpd/branches/2.2.x/STATUS
    httpd/httpd/branches/2.2.x/srclib/pcre/printint.c

Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?view=diff&rev=495134&r1=495133&r2=495134
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Wed Jan 10 21:53:09 2007
@@ -96,21 +96,6 @@
         going on in this patch to no net effect.  The WAIT_TIMEOUT
         result value seems to be ignored in the revised code?
 
-    * Bundled PCRE: backport r381783 from trunk
-      Fix brokenness on certain platforms when building with -DDEBUG.
-      http://svn.apache.org/viewvc?view=rev&revision=381783
-      +1 sctemme, fielding, pquerna, jerenkrantz
-      -1 niq: Why are we hacking a third-party package as bundled,
-              rather than upstream?  This has potential for chaos
-              for modules (and we have a history of PCRE trouble)
-              as well as a maintenance nightmare!
-      jerenkrantz: I don't believe that's a valid reason to block this.
-                   We're bundling PCRE for the duration of the 2.2.x series,
-                   but we can re-evaluate for future major/minor revs.
-      wrowe: nak niq, ack je; this is a silly debate, fix, push fixes upstream
-             and adopt a newer PCRE at trunk/.
-      niq: see http://mail-archives.apache.org/mod_mbox/httpd-dev/200611.mbox/raw/%3c20061108180201.6ad45937@grimnir%3e/
-
     * PKCS#7: backport PCKS#7 patches from trunk.
       +1 ben
       jerenkrantz: What's the revision number to backport?

Modified: httpd/httpd/branches/2.2.x/srclib/pcre/printint.c
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/srclib/pcre/printint.c?view=diff&rev=495134&r1=495133&r2=495134
==============================================================================
--- httpd/httpd/branches/2.2.x/srclib/pcre/printint.c (original)
+++ httpd/httpd/branches/2.2.x/srclib/pcre/printint.c Wed Jan 10 21:53:09 2007
@@ -107,6 +107,7 @@
 
 
 
+#ifdef SUPPORT_UCP
 /*************************************************
 *          Find Unicode property name            *
 *************************************************/
@@ -121,6 +122,7 @@
   }
 return (i >= 0)? utt[i].name : "??";
 }
+#endif /* SUPPORT_UCP */
 
 
 
@@ -255,11 +257,13 @@
     if (*code >= OP_TYPESTAR)
       {
       fprintf(f, "%s", OP_names[code[1]]);
+#ifdef SUPPORT_UCP
       if (code[1] == OP_PROP || code[1] == OP_NOTPROP)
         {
         fprintf(f, " %s ", get_ucpname(code[2]));
         extra = 1;
         }
+#endif
       }
     else extra = print_char(f, code+1, utf8);
     fprintf(f, "%s", OP_names[*code]);
@@ -280,11 +284,13 @@
     case OP_TYPEUPTO:
     case OP_TYPEMINUPTO:
     fprintf(f, "    %s", OP_names[code[3]]);
+#ifdef SUPPORT_UCP
     if (code[3] == OP_PROP || code[3] == OP_NOTPROP)
       {
       fprintf(f, " %s ", get_ucpname(code[4]));
       extra = 1;
       }
+#endif
     fprintf(f, "{");
     if (*code != OP_TYPEEXACT) fprintf(f, "0,");
     fprintf(f, "%d}", GET2(code,1));
@@ -331,10 +337,12 @@
       GET(code, 2 + LINK_SIZE));
     break;
 
+#ifdef SUPPORT_UCP
     case OP_PROP:
     case OP_NOTPROP:
     fprintf(f, "    %s %s", OP_names[*code], get_ucpname(code[1]));
     break;
+#endif
 
     /* OP_XCLASS can only occur in UTF-8 mode. However, there's no harm in
     having this code always here, and it makes it less messy without all those
@@ -394,6 +402,7 @@
         int ch;
         while ((ch = *ccode++) != XCL_END)
           {
+#ifdef SUPPORT_UCP
           if (ch == XCL_PROP)
             {
             fprintf(f, "\\p{%s}", get_ucpname(*ccode++));
@@ -403,6 +412,7 @@
             fprintf(f, "\\P{%s}", get_ucpname(*ccode++));
             }
           else
+#endif
             {
             ccode += 1 + print_char(f, ccode, TRUE);
             if (ch == XCL_RANGE)



Mime
View raw message