httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wr...@apache.org
Subject svn commit: r483547 - /httpd/httpd/branches/2.2.x/STATUS
Date Thu, 07 Dec 2006 17:01:51 GMT
Author: wrowe
Date: Thu Dec  7 09:01:50 2006
New Revision: 483547

URL: http://svn.apache.org/viewvc?view=rev&rev=483547
Log:

  Mostly acks, a couple naks and a Q or two

Modified:
    httpd/httpd/branches/2.2.x/STATUS

Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?view=diff&rev=483547&r1=483546&r2=483547
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Thu Dec  7 09:01:50 2006
@@ -85,7 +85,7 @@
         http://svn.apache.org/viewvc?view=rev&revision=428029
       2.2.x version of patch:
         Trunk version works
-      +1: mturk
+      +1: mturk, wrowe
 
     * Bundled PCRE: backport r381783 from trunk
       Fix brokenness on certain platforms when building with -DDEBUG.
@@ -98,10 +98,13 @@
       jerenkrantz: I don't believe that's a valid reason to block this.
                    We're bundling PCRE for the duration of the 2.2.x series,
                    but we can re-evaluate for future major/minor revs.
+      wrowe: nak niq, ack je; this is a silly debate, fix, push fixes upstream
+             and adopt a newer PCRE at trunk/.
 
     * PKCS#7: backport PCKS#7 patches from trunk.
       +1 ben
       jerenkrantz: What's the revision number to backport?
+      wrowe asks: ditto jerenkrantz
 
     * mod_deflate: Rework inflate output and deflate output filter to fix
       several issues: Incorrect handling of flush buckets, potential memory
@@ -147,6 +150,8 @@
         The patch for the inflate output filter requires the patch for the
         deflate output filter.
       +1: rpluem, niq
+      wrowe notes: I can't vote on this, nor can most; if you mean to propose
+      backporting trunk/ to branches/2.2 for mod_deflate, I'd back that.
 
     * Allow htcacheclean and httxt2dbm to link apr/apr-util statically
       like the older support programs.
@@ -154,34 +159,39 @@
         http://svn.apache.org/viewvc?view=rev&revision=441796
       2.2.x version of patch:
         http://mail-archives.apache.org/mod_mbox//httpd-dev/200609.mbox/%3c1404e5910609091218p84f4d2flc1000764b4966727@mail.gmail.com%3e
-      +1: trawick
+      +1: trawick, wrowe
 
     * mod_cgi and mod_cgid: Don't use apr_status_t error return
       from input filters as HTTP return value from the handler.
       PR#31579.
       Trunk: http://svn.apache.org/viewvc?view=rev&revision=442758
-      +1: niq, bnicholes
+      +1: niq, bnicholes, wrowe
 
     * mod_proxy: Support variable interpolation in reverse proxy configuration
       http://svn.apache.org/viewvc?view=rev&revision=421686  (code)
       http://svn.apache.org/viewvc?view=rev&revision=422178  (code)
       http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/manual/mod/mod_proxy.xml?r1=420990&r2=421725
(docs)
       +1: niq, mturk
+      -.9: wrowe notes; modifying the existing syntax seems inappropriate, new
+           ProxyPassSubstitute or similarly named directives would seem to
+           make more sense, permit direct Reverse'als when appropriate and
+           restrict the Substitutions to be parsed only when required.
 
     * mod_mem_cache: Memory leak fix: Unconditionally free the buffer.
       Trunk: http://svn.apache.org/viewvc?view=rev&revision=450070
-      +1: minfrin, jim
+      +1: minfrin, jim, wrowe
+        wrowe asks; should ptr mobj->m be nulled out for safety's sake?
 
     * mod_mem_cache: Convert mod_mem_cache to use APR memory pool functions
       by creating a root pool for object persistence across requests. This
       also eliminates the need for custom serialization code.
       Trunk: http://svn.apache.org/viewvc?view=rev&revision=450089
-      +1: minfrin, jim
+      +1: minfrin, jim, wrowe
 
     * mod_cache: Eliminate a bogus error in the log when a filter returns
       AP_FILTER_ERROR.
       Trunk: http://svn.apache.org/viewvc?view=rev&rev=450453
-      +1: minfrin
+      +1: minfrin, wrowe
 
     * core: Orphaned piped logger process after graceful restart
         PR: 40651
@@ -189,7 +199,7 @@
         http://svn.apache.org/viewvc?view=rev&rev=452431
       2.2.x version of patch:
         Trunk version works
-      +1: rpluem, trawick
+      +1: rpluem, trawick, wrowe
 
     * mod_authnz_ldap: Add an AuthLDAPRemoteUserAttribute directive. If
       set, REMOTE_USER will be set to this attribute, rather than the
@@ -197,7 +207,7 @@
       to log in using an email address, but need to supply a userid instead
       to the backend.
       Trunk: http://svn.apache.org/viewvc?view=rev&rev=463427
-      +1: minfrin
+      +1: minfrini, wrowe
 
    * mod_dumpio: Allow logging at other LogLevels via DumpIOLogLevel
      directive.
@@ -205,7 +215,9 @@
         http://svn.apache.org/viewvc?view=rev&revision=463291
       2.2.x version of patch:
         http://people.apache.org/~jim/patches/dumpio-patch.txt
-      +1: jim
+      +1: jim, wrowe
+      wrowe asks: isn't it time to make LogLevel directive parsing
+                  reusable in the ap_config api?
 
    * mod_dbd: Key the storage of prepared statements on the hex string
      value of server_rec, rather than the server name, as the server name
@@ -216,7 +228,7 @@
           which were not yet backported.  They fix a nasty bug,
           and minfrin's fix is better than mine.
      Cumulative patch: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/database/mod_dbd.c?r1=466641&r2=420983&pathrev=466641
-     +1: minfrin, niq
+     +1: minfrin, niq, wrowe
 
    * mod_authn_dbd: Export any additional columns queried in the SQL select
      into the environment with the name AUTHENTICATE_<COLUMN>. This brings
@@ -227,6 +239,7 @@
           strlen of something defined elsewhere) is nasty.  More importantly
           you need to document how it affects the module's directives.
           I'll +1 it when that's done.
+     wrowe: ditto's - good concept.
 
    * Fix address-in-use startup failure caused by corruption of the list of
      listen sockets in some configurations with multiple generic Listen
@@ -235,16 +248,18 @@
        http://svn.apache.org/viewvc?view=rev&revision=467034
      2.2.x version of patch:
        Trunk version works
-     +1: trawick, jim
+     +1: trawick, jim, wrowe
 
    * mod_headers: support regexp-based manipulation
      http://svn.apache.org/viewvc?view=rev&revision=452330
-     +1: niq, chrisd
+     +1: niq, chrisd, wrowe
 
    * mod_ldap: Better detection and clean up of ldap connection
      that have been terminated by the ldap server.
      http://svn.apache.org/viewvc?view=rev&revision=472633
-     +1: bnicholes, jim
+     +1: bnicholes, jim, wrowe
+     wrowe adds; keeping the old idents for backporting would have
+                 made this alot easier for review - mind \x09's please.
 
    * core: Allow AcceptMutex to accept pathname arguments ala SSLMutex,
      and, as a result, semi-depreciate Lockfile.
@@ -255,6 +270,9 @@
        Trunk version works (requires handling of CHANGES and ap_mmn.h
        conflict though)
      +1: jim
+     +1/-.9: wrowe
+     wrowe notes: Adding to ease migration to 2.4 - good.  Deprecating 
+                  any directive in a .even released branch, bad.
 
    * rotatelogs: Produce useful error messages for open() failures.
      PR 39487
@@ -262,5 +280,8 @@
        http://svn.apache.org/viewvc?view=rev&revision=478135
      2.2.x version of patch:
        Trunk version works.
-     +1: trawick
+     +1: trawick, wrowe
+     wrowe notes: 26 bytes is absurdly posix-unix and english specific,
+                  don't you think?  grow the error text pad to a sane
+                  width before backporting, please.
 



Mime
View raw message