httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From roo...@apache.org
Subject svn commit: r366985 - /httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c
Date Sun, 08 Jan 2006 04:48:51 GMT
Author: rooneg
Date: Sat Jan  7 20:48:50 2006
New Revision: 366985

URL: http://svn.apache.org/viewcvs?rev=366985&view=rev
Log:
In theory, we now correctly implement all of the FastCGI protocol, so
there's no reason that request ids wouldn't be matching up.  Until we
see an example of a request id mismatch error that is absolutely not
caused by an error in our parsing of the FastCGI protocol, we should
be able to go back to treating mismatches as errors.

* modules/proxy/mod_proxy_fcgi.c
  (dispatch): Remove #ifdef that turned off treating rid mismatches as
   fatal errors.

Modified:
    httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c

Modified: httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c
URL: http://svn.apache.org/viewcvs/httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c?rev=366985&r1=366984&r2=366985&view=diff
==============================================================================
--- httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c (original)
+++ httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c Sat Jan  7 20:48:50
2006
@@ -502,10 +502,8 @@
                 ap_log_error(APLOG_MARK, APLOG_ERR, 0, r->server,
                              "proxy: FCGI: Got bogus rid %d, expected %d",
                              rid, request_id);
-#if defined(RID_MISMATCH_IS_TERMINAL_ERROR)
                 rv = APR_EINVAL;
                 break;
-#endif
             }
 
             clen = header[FCGI_HDR_CONTENT_LEN_B1_OFFSET] << 8;



Mime
View raw message