httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r230733 - /httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
Date Mon, 08 Aug 2005 12:11:39 GMT
At 09:51 PM 8/7/2005, wrowe@apache.org wrote:
>Author: wrowe
>Date: Sun Aug  7 19:51:32 2005
>New Revision: 230733
>
>URL: http://svn.apache.org/viewcvs?rev=230733&view=rev
>Log:
>
>  Fix a double-termination case in svn trunk/; we terminated the
>  headers up-front knowing the resulting headers were already
>  correctly composed.
>
>--- httpd/httpd/trunk/modules/proxy/mod_proxy_http.c (original)
>+++ httpd/httpd/trunk/modules/proxy/mod_proxy_http.c Sun Aug  7 19:51:32 2005
>@@ -398,7 +398,6 @@
>         /* we never sent the header brigade since there was no request
>          * body; send it now with the flush flag
>          */
>-        terminate_headers(bucket_alloc, header_brigade);

Joe - this was an evil thing; try your regressions now.  I expect
you will be happier.  But I'm not even sure if you ever touched
this specific case.

My other thought is the choice of bucket allocators; notice that
we seem to be using both r->connection->bucket_alloc, and also
origin->bucket->alloc.  I don't believe this is a new flaw.

Thanks to both you and Andre for catching a few sprintf style
formatting bugs (misplaced commas) while I was on vacation; 
they are correct in the branch created for evaluating the 
backport.  Not certain if that too was part of your failures.

If you can provide an update on any segfaults you see on svn
trunk/, as well as the t/proxy suite results, that would be
fantastic.

Bill




Mime
View raw message