httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From max...@apache.org
Subject svn commit: r264707 - in /httpd/mod_mbox/branches/httpd-mbox-if: STATUS data/archives.js module-2.0/mod_mbox_index.c module-2.0/mod_mbox_out.c
Date Tue, 30 Aug 2005 04:51:15 GMT
Author: maxime
Date: Mon Aug 29 21:51:10 2005
New Revision: 264707

URL: http://svn.apache.org/viewcvs?rev=264707&view=rev
Log:
UI improvments.

 * module-2.0/mod_mbox_index.c:
    (mbox_index_handler): tweaked title and list information.

 * module-2.0/mod_mbox_out.c, data/archives.js:
    (mbox_static_boxlist, buildBoxListEntry): added a title attribute
to box list entries.

 * STATUS:
    Added Opera to the list of known non-working browsers.


Modified:
    httpd/mod_mbox/branches/httpd-mbox-if/STATUS
    httpd/mod_mbox/branches/httpd-mbox-if/data/archives.js
    httpd/mod_mbox/branches/httpd-mbox-if/module-2.0/mod_mbox_index.c
    httpd/mod_mbox/branches/httpd-mbox-if/module-2.0/mod_mbox_out.c

Modified: httpd/mod_mbox/branches/httpd-mbox-if/STATUS
URL: http://svn.apache.org/viewcvs/httpd/mod_mbox/branches/httpd-mbox-if/STATUS?rev=264707&r1=264706&r2=264707&view=diff
==============================================================================
--- httpd/mod_mbox/branches/httpd-mbox-if/STATUS (original)
+++ httpd/mod_mbox/branches/httpd-mbox-if/STATUS Mon Aug 29 21:51:10 2005
@@ -64,4 +64,8 @@
         .innerHTML, but I was not able to reproduce them outside
         mod_mbox (http://skikda.bulix.org/~sam/ajax/compat.html).
 
+    Opera:
 
+      * The AJAX browsing interface does not work. All the data is
+        here and loaded, but it's displayed as if the browser did not
+        even care of the generated XHTML content.

Modified: httpd/mod_mbox/branches/httpd-mbox-if/data/archives.js
URL: http://svn.apache.org/viewcvs/httpd/mod_mbox/branches/httpd-mbox-if/data/archives.js?rev=264707&r1=264706&r2=264707&view=diff
==============================================================================
--- httpd/mod_mbox/branches/httpd-mbox-if/data/archives.js (original)
+++ httpd/mod_mbox/branches/httpd-mbox-if/data/archives.js Mon Aug 29 21:51:10 2005
@@ -521,6 +521,10 @@
 function buildBoxListEntry (box)
 {
   var id = box.getAttribute('id');
+
+  /* The decimal base (10) is passed to parseInt in order to avoid
+     octal parsing due to leading 0. */
+  var month = parseInt(id.substr(4, 2), 10);
   var str = '';
 
   /* If the mbox id is the same as the one who called the
@@ -536,17 +540,14 @@
   str += '<td class="box">';
 
   if (id == _mbox) {
-    str += '<a href="browser" onclick="javascript:drawFullMsgList(); return false;">';
+    str += '<a href="browser" onclick="javascript:drawFullMsgList(); return false;"';
   }
   else {
-    str += '<a href="' + _baseURI + id + '/browser">';
+    str += '<a href="' + _baseURI + id + '/browser"';
   }
 
-  /* Display month name (short text) and year. The decimal
-     base (10) is passed to parseInt in order to avoid octal
-     parsing due to leading 0. */
-  str += getMonthName(parseInt(id.substr(4, 2), 10), false) +
-    ' ' + id.substr(0, 4) + '</a></td>';
+  str += ' title="Browse ' + getMonthName(month, true) + ' ' + id.substr(0, 4) +
+    ' archives">' + getMonthName(month, false) + ' ' + id.substr(0, 4) + '</a></td>';
 
   /* Finally end the entry with the message count */
   str += '<td class="msgcount">' + box.getAttribute('count') +

Modified: httpd/mod_mbox/branches/httpd-mbox-if/module-2.0/mod_mbox_index.c
URL: http://svn.apache.org/viewcvs/httpd/mod_mbox/branches/httpd-mbox-if/module-2.0/mod_mbox_index.c?rev=264707&r1=264706&r2=264707&view=diff
==============================================================================
--- httpd/mod_mbox/branches/httpd-mbox-if/module-2.0/mod_mbox_index.c (original)
+++ httpd/mod_mbox/branches/httpd-mbox-if/module-2.0/mod_mbox_index.c Mon Aug 29 21:51:10
2005
@@ -145,37 +145,36 @@
     ap_rputs(" </head>\n\n", r);
 
     ap_rputs(" <body id=\"archives\" onload=\"indexLinks ();\">\n", r);
-    ap_rputs("  <h1>Mailing list archives</h1>\n\n", r);
+    ap_rprintf(r, "  <h1>Mailing list archives: %s@%s</h1>\n\n",
+	       ESCAPE_OR_BLANK(r->pool, mli->list),
+	       ESCAPE_OR_BLANK(r->pool, mli->domain));
 
     /* Output header and list information */
     ap_rputs("  <table id=\"listinfo\">\n", r);
     ap_rputs("   <thead><tr><th colspan=\"2\">List information</th></tr></thead>\n",
r);
     ap_rputs("   <tbody>\n", r);
 
-    ap_rprintf(r, "    <tr><td class=\"left\">List name</td>"
-	       "<td class=\"right\">%s</td></tr>\n",
-	       ESCAPE_OR_BLANK(r->pool, mli->list));
-
-    ap_rprintf(r, "    <tr><td class=\"left\">Domain</td>"
-	       "<td class=\"right\">%s</td></tr>\n",
+    ap_rprintf(r, "    <tr><td class=\"left\">Writing to the list</td>"
+	       "<td class=\"right\">%s@%s</td></tr>\n",
+	       ESCAPE_OR_BLANK(r->pool, mli->list),
 	       ESCAPE_OR_BLANK(r->pool, mli->domain));
 
-    ap_rprintf(r, "    <tr><td class=\"left\">Subscribe</td>"
+    ap_rprintf(r, "    <tr><td class=\"left\">Subscription address</td>"
 	       "<td class=\"right\">%s-subscribe@%s</td></tr>\n",
 	       ESCAPE_OR_BLANK(r->pool, mli->list),
 	       ESCAPE_OR_BLANK(r->pool, mli->domain));
 
-    ap_rprintf(r, "    <tr><td class=\"left\">Digest</td>"
+    ap_rprintf(r, "    <tr><td class=\"left\">Digest subscription address</td>"
 	       "<td class=\"right\">%s-digest-subscribe@%s</td></tr>\n",
 	       ESCAPE_OR_BLANK(r->pool, mli->list),
 	       ESCAPE_OR_BLANK(r->pool, mli->domain));
 
-    ap_rprintf(r, "    <tr><td class=\"left\">Unsubscribe</td>"
+    ap_rprintf(r, "    <tr><td class=\"left\">Unsubscription addresses</td>"
 	       "<td class=\"right\">%s-unsubscribe@%s</td></tr>\n",
 	       ESCAPE_OR_BLANK(r->pool, mli->list),
 	       ESCAPE_OR_BLANK(r->pool, mli->domain));
 
-    ap_rprintf(r, "    <tr><td class=\"left\">Help</td>"
+    ap_rprintf(r, "    <tr><td class=\"left\">Getting help with the list</td>"
 	       "<td class=\"right\">%s-help@%s</td></tr>\n",
 	       ESCAPE_OR_BLANK(r->pool, mli->list),
 	       ESCAPE_OR_BLANK(r->pool, mli->domain));

Modified: httpd/mod_mbox/branches/httpd-mbox-if/module-2.0/mod_mbox_out.c
URL: http://svn.apache.org/viewcvs/httpd/mod_mbox/branches/httpd-mbox-if/module-2.0/mod_mbox_out.c?rev=264707&r1=264706&r2=264707&view=diff
==============================================================================
--- httpd/mod_mbox/branches/httpd-mbox-if/module-2.0/mod_mbox_out.c (original)
+++ httpd/mod_mbox/branches/httpd-mbox-if/module-2.0/mod_mbox_out.c Mon Aug 29 21:51:10 2005
@@ -140,12 +140,17 @@
 	        ap_rputs("   <tr>", r);
 	    }
 
-	    ap_rprintf(r, "<td class=\"box\"><a href=\"%s/%s%s\">%s %.4s</a></td>"
-		       "<td class=\"msgcount\">%d</td></tr>\n",
+	    ap_rprintf(r, "    <td class=\"box\"><a href=\"%s/%s%s\" title=\"Browse %s
%.4s archives\">"
+		       "%s %.4s</a></td><td class=\"msgcount\">%d</td>\n",
 		       base_path, files[i].filename, r->path_info,
 		       mbox_months[atoi(apr_pstrndup(r->pool,
+						     files[i].filename+4, 2)) - 1][1],
+		       files[i].filename,
+ 		       mbox_months[atoi(apr_pstrndup(r->pool,
 						     files[i].filename+4, 2)) - 1][0],
 		       files[i].filename, files[i].count);
+
+	    ap_rputs("   </tr>\n", r);
 	}
     }
 



Mime
View raw message