On Mon, Aug 08, 2005 at 07:11:39AM -0500, William Rowe wrote:
> At 09:51 PM 8/7/2005, wrowe@apache.org wrote:
> >Author: wrowe
> >Date: Sun Aug 7 19:51:32 2005
> >New Revision: 230733
> >
> >URL: http://svn.apache.org/viewcvs?rev=230733&view=rev
> >Log:
> >
> > Fix a double-termination case in svn trunk/; we terminated the
> > headers up-front knowing the resulting headers were already
> > correctly composed.
> >
> >--- httpd/httpd/trunk/modules/proxy/mod_proxy_http.c (original)
> >+++ httpd/httpd/trunk/modules/proxy/mod_proxy_http.c Sun Aug 7 19:51:32 2005
> >@@ -398,7 +398,6 @@
> > /* we never sent the header brigade since there was no request
> > * body; send it now with the flush flag
> > */
> >- terminate_headers(bucket_alloc, header_brigade);
>
> Joe - this was an evil thing; try your regressions now. I expect
> you will be happier. But I'm not even sure if you ever touched
> this specific case.
Great, yes with last night's regression run the segfaults with worker
were gone and the tests are all passing for prefork and worker again on
the trunk - thanks a lot Bill. -Werror builds are failing though:
mod_proxy_http.c: In function `ap_proxy_http_request':
mod_proxy_http.c:312: warning: 'status' might be used uninitialized in
this function
joe
|