httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wr...@apache.org
Subject svn commit: r124283 - /httpd/httpd/trunk/server/protocol.c
Date Wed, 05 Jan 2005 22:21:58 GMT
Author: wrowe
Date: Wed Jan  5 14:21:56 2005
New Revision: 124283

URL: http://svn.apache.org/viewcvs?view=rev&rev=124283
Log:

  limit_req_fieldsize is signed, correct a signedness error using
  a cast since it's not possible to have a negative limit.

Modified:
   httpd/httpd/trunk/server/protocol.c

Modified: httpd/httpd/trunk/server/protocol.c
Url: http://svn.apache.org/viewcvs/httpd/httpd/trunk/server/protocol.c?view=diff&rev=124283&p1=httpd/httpd/trunk/server/protocol.c&r1=124282&p2=httpd/httpd/trunk/server/protocol.c&r2=124283
==============================================================================
--- httpd/httpd/trunk/server/protocol.c	(original)
+++ httpd/httpd/trunk/server/protocol.c	Wed Jan  5 14:21:56 2005
@@ -708,7 +708,7 @@
                  */
                 apr_size_t fold_len = last_len + len + 1; /* trailing null */
 
-                if (fold_len > r->server->limit_req_fieldsize + 1) {
+                if (fold_len >= (apr_size_t)(r->server->limit_req_fieldsize)) {
                     r->status = HTTP_BAD_REQUEST;
                     /* report what we have accumulated so far before the
                      * overflow (last_field) as the field with the problem

Mime
View raw message