httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r109447 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c
Date Thu, 02 Dec 2004 13:35:36 GMT
On Thu, Dec 02, 2004 at 04:25:53AM -0000, Paul Querna wrote:
> Author: pquerna
> Date: Wed Dec  1 20:25:52 2004
> New Revision: 109447
> 
> URL: http://svn.apache.org/viewcvs?view=rev&rev=109447
> Log:
> Use a case insensitive compare when looking for 'Upgrade'.
> The first client I tested was sending 'upgrade'.

That whole chunk of code is actually not necessary at all, the right fix
is to just remove it completely...

> Modified:
>    httpd/httpd/trunk/modules/ssl/ssl_engine_io.c
> 
> Modified: httpd/httpd/trunk/modules/ssl/ssl_engine_io.c
> Url: http://svn.apache.org/viewcvs/httpd/httpd/trunk/modules/ssl/ssl_engine_io.c?view=diff&rev=109447&p1=httpd/httpd/trunk/modules/ssl/ssl_engine_io.c&r1=109446&p2=httpd/httpd/trunk/modules/ssl/ssl_engine_io.c&r2=109447
> ==============================================================================
> --- httpd/httpd/trunk/modules/ssl/ssl_engine_io.c	(original)
> +++ httpd/httpd/trunk/modules/ssl/ssl_engine_io.c	Wed Dec  1 20:25:52 2004
> @@ -1213,7 +1213,7 @@
>  
>      token_string = apr_pstrdup(r->pool,connection);
>      token = apr_strtok(token_string,",",&token_state);
> -    while (token && strcmp(token,"Upgrade")) {
> +    while (token && strcasecmp(token,"Upgrade")) {
>          apr_strtok(NULL,",",&token_state);
>      }
>      /* "Connection: Upgrade" header not found, don't do Upgrade */

Mime
View raw message