httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From n.@apache.org
Subject cvs commit: httpd-2.0/modules/mappers mod_rewrite.c
Date Tue, 27 Jan 2004 00:43:41 GMT
nd          2004/01/26 16:43:41

  Modified:    modules/mappers mod_rewrite.c
  Log:
  issue a warning if an external rewrite map is used without RewriteLock.
  
  Revision  Changes    Path
  1.249     +8 -0      httpd-2.0/modules/mappers/mod_rewrite.c
  
  Index: mod_rewrite.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/mappers/mod_rewrite.c,v
  retrieving revision 1.248
  retrieving revision 1.249
  diff -u -u -r1.248 -r1.249
  --- mod_rewrite.c	27 Jan 2004 00:22:10 -0000	1.248
  +++ mod_rewrite.c	27 Jan 2004 00:43:41 -0000	1.249
  @@ -1206,6 +1206,7 @@
       rewrite_server_conf *conf;
       apr_hash_index_t *hi;
       apr_status_t rc;
  +    int lock_warning_issued = 0;
   
       conf = ap_get_module_config(s->module_config, &rewrite_module);
   
  @@ -1230,6 +1231,13 @@
           }
           if (!(map->argv[0]) || !*(map->argv[0]) || map->fpin || map->fpout)
{
               continue;
  +        }
  +
  +        if (!lock_warning_issued && (!lockname || !*lockname)) {
  +            ap_log_error(APLOG_MARK, APLOG_WARNING, 0, s,
  +                         "mod_rewrite: Running external rewrite maps "
  +                         "without defining a RewriteLock is DANGEROUS!");
  +            ++lock_warning_issued;
           }
   
           rc = rewritemap_program_child(p, map->argv[0], map->argv,
  
  
  

Mime
View raw message