Return-Path: Delivered-To: apmail-httpd-cvs-archive@www.apache.org Received: (qmail 17964 invoked from network); 3 Dec 2003 05:44:30 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 3 Dec 2003 05:44:30 -0000 Received: (qmail 35396 invoked by uid 500); 3 Dec 2003 05:44:02 -0000 Delivered-To: apmail-httpd-cvs-archive@httpd.apache.org Received: (qmail 35311 invoked by uid 500); 3 Dec 2003 05:44:02 -0000 Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list cvs@httpd.apache.org Received: (qmail 35263 invoked by uid 500); 3 Dec 2003 05:44:01 -0000 Delivered-To: apmail-httpd-2.0-cvs@apache.org Received: (qmail 35200 invoked from network); 3 Dec 2003 05:44:01 -0000 Received: from unknown (HELO www.sodan.org) (210.224.163.21) by daedalus.apache.org with SMTP; 3 Dec 2003 05:44:01 -0000 Received: from mito.sodan.org.logos.t.u-tokyo.ac.jp (localhost [127.0.0.1]) by www.sodan.org (8.9.3p2+3.2W/3.7W/Sodan.smtpfeed) with ESMTP id OAA16968; Wed, 3 Dec 2003 14:44:09 +0900 To: dev@httpd.apache.org Cc: httpd-2.0-cvs@apache.org Subject: Re: cvs commit: httpd-2.0/docs/manual/mod mpm_common.xml mpm_winnt.xml From: Yoshiki Hayashi MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Date: Tue, 02 Dec 2003 22:43:17 -0700 In-Reply-To: <20031120201213.7757.qmail@minotaur.apache.org> (stoddard@apache.org's message of "20 Nov 2003 20:12:13 -0000") Message-ID: <87k75etq16.fsf@mito.sodan.org> User-Agent: T-gnus/6.15.16 (based on Oort Gnus v0.16) References: <20031120201213.7757.qmail@minotaur.apache.org> X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N stoddard@apache.org writes: > stoddard 2003/11/20 12:12:13 > > Modified: docs/manual/mod mpm_common.xml mpm_winnt.xml > Log: > Win32: MaxMemFree works with mpm_winnt I noticed this change while I was trying to backport Japanese translation of 2.1 document to 2.0. Since this change is only done in 2.1, I dived into source code whether this applies to 2.0 or not. AP_INIT_TAKE1("MaxMemFree" in core.c is same and ap_mpm_set_max_mem_free in mpm_common.c is also same. And mpm_winnt.c is same, so MaxMemFree should also work on Win32 in 2.0, right? One thing that puzzled me while checking the code is that mpm_winnt.c doesn't call apr_allocator_max_free_set like any other MPMs (except perchild). Doesn't it have to call it, too? -- Yoshiki Hayashi