httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wr...@apache.org
Subject cvs commit: httpd-2.0 STATUS
Date Thu, 17 Apr 2003 18:46:27 GMT
wrowe       2003/04/17 11:46:27

  Modified:    .        Tag: APACHE_2_0_BRANCH STATUS
  Log:
    Boy did I misread the underlying problem when I first commented.
    Offer a suggestion for viewers of history before we finally get
    the whole thing correctly sorted out.
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.751.2.223 +9 -9      httpd-2.0/STATUS
  
  Index: STATUS
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/STATUS,v
  retrieving revision 1.751.2.222
  retrieving revision 1.751.2.223
  diff -u -r1.751.2.222 -r1.751.2.223
  --- STATUS	17 Apr 2003 18:20:58 -0000	1.751.2.222
  +++ STATUS	17 Apr 2003 18:46:24 -0000	1.751.2.223
  @@ -69,14 +69,14 @@
         branch won't build for Windows.
         CHANGES 1.1145 
         server/mpm_common.c 1.107
  -      +1: ake, trawick, stoddard
  -      -1: wrowe
  -          wrowe notes: I don't dislike the patch - but the breakage illustrates
  -                       breakage in APR.  Why?  Because APR is not in the business
  -                       of exposing undecorated names.  I suggest we go back to
  -                       square one, decorate the change to apr.hw, and when we
  -                       start patching for 2.1-dev/2.0 - test for APR_TCP_NODELAY
  -                       as well as TCP_NODELAY.
  +      +1: ake, trawick, stoddard, wrowe
  +          wrowe notes: /me misunderstood the breakage.  We explicitly excluded
  +                       the implementation, but not the prototype(!), for the
  +                       ap_sock_disable_nagle() function.  APR isn't implicated
  +                       at all, this was a latent bug.  I'm just asking that we
  +                       first commit a patch excluding the prototype in favor of
  +                       the /*NOOP*/ define, just to document the progression
  +                       from no-nagling to an implemented ap_sock_disable_nagle.
                          
   
       * AllowEncodedSlashes patch to permit %2f in path-info.
  
  
  

Mime
View raw message