httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject cvs commit: httpd-2.0 STATUS
Date Wed, 29 Jan 2003 08:49:45 GMT
jwoolley    2003/01/29 00:49:45

  Modified:    .        Tag: APACHE_2_0_BRANCH STATUS
  Finallllly got around to testing mod_file_cache.  Looks good to me.  Both
  Bill's and my patches need to be merged in, but we might as well do them
  at the same time.  Which means somebody else needs to look at Bill's and
  +1 it.
  Here's why it's right:  Since there's no transfer_ownership flag on
  apr_mmap_dup() anymore [or rather, since it's now ignored pending an API
  change at a later date to remove it], the only indication of whether an
  mmap should be deleted or not is the refcount.  The core will now
  delete any apr_mmap_t it encounters when it's done with it.  Before
  Bill's patch, we had exactly two copies of each apr_mmap_t: one to hang
  onto, and one that we passed to all requests.  But the very first
  request would delete that second one, so subsequent requests would be
  botched.  Each request needs its own dup of the original apr_mmap_t that
  we hang onto now that there's no ownership flag to prevent a request from
  deleting the shared apr_mmap_t we had before.
  Revision  Changes    Path
  No                   revision
  No                   revision
  1.751.2.70 +3 -3      httpd-2.0/STATUS
  Index: STATUS
  RCS file: /home/cvs/httpd-2.0/STATUS,v
  retrieving revision 1.751.2.69
  retrieving revision 1.751.2.70
  diff -u -d -u -r1.751.2.69 -r1.751.2.70
  --- STATUS	29 Jan 2003 05:11:24 -0000	1.751.2.69
  +++ STATUS	29 Jan 2003 08:49:44 -0000	1.751.2.70
  @@ -65,11 +65,11 @@
         serving the response. This fixes segfault observed on
         windows serving mmap cached files.
         modules/cache/mod_file_cache.c r1.76
  -      +1: stoddard
  +      +1: stoddard, jwoolley
       * mod_file_cache segfault bugfix. PR 16313.
         modules/cache/mod_file_cache.c r1.75
  -     +1: stoddard, orlikowski, striker
  +     +1: stoddard, orlikowski, striker, jwoolley
       * Rewrite how proxy sends its request to allow input bodies to 
         morph the request bodies.  Previously, if an input filter

View raw message