httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rasmus Lerdorf <ras...@apache.org>
Subject Re: cvs commit: httpd-2.0/modules/filters mod_deflate.c
Date Sun, 10 Nov 2002 06:29:39 GMT
Shouldn't you also Vary on User-Agent when a BrowserMatch no-gzip is
present?

On 10 Nov 2002 jerenkrantz@apache.org wrote:

> jerenkrantz    2002/11/09 22:09:20
>
>   Modified:    .        CHANGES
>                modules/filters mod_deflate.c
>   Log:
>   Always emit Vary header if mod_deflate is involved in the request.
>
>   Submitted by:	AndréMalo <nd@perlig.de>
>   Reviewed by:	Justin Erenkrantz
>
>   Revision  Changes    Path
>   1.975     +3 -0      httpd-2.0/CHANGES
>
>   Index: CHANGES
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/CHANGES,v
>   retrieving revision 1.974
>   retrieving revision 1.975
>   diff -u -u -r1.974 -r1.975
>   --- CHANGES	9 Nov 2002 19:21:29 -0000	1.974
>   +++ CHANGES	10 Nov 2002 06:09:19 -0000	1.975
>   @@ -1,5 +1,8 @@
>    Changes with Apache 2.0.44
>
>   +  *) Always emit Vary header if mod_deflate is involved in the
>   +     request.  [AndréMalo <nd@perlig.de>]
>   +
>      *) mod_isapi: Stop unsetting the 'empty' query string result with
>         a NULL argument in ecb->lpszQueryString, eliminating segfaults
>         for some ISAPI modules.  PR 14399
>
>
>
>   1.25      +6 -1      httpd-2.0/modules/filters/mod_deflate.c
>
>   Index: mod_deflate.c
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/modules/filters/mod_deflate.c,v
>   retrieving revision 1.24
>   retrieving revision 1.25
>   diff -u -u -r1.24 -r1.25
>   --- mod_deflate.c	30 Aug 2002 16:31:17 -0000	1.24
>   +++ mod_deflate.c	10 Nov 2002 06:09:20 -0000	1.25
>   @@ -306,6 +306,12 @@
>                }
>            }
>
>   +        /* Even if we don't accept this request based on it not having
>   +         * the Accept-Encoding, we need to note that we were looking
>   +         * for this header and downstream proxies should be aware of that.
>   +         */
>   +        apr_table_setn(r->headers_out, "Vary", "Accept-Encoding");
>   +
>            /* if they don't have the line, then they can't play */
>            accepts = apr_table_get(r->headers_in, "Accept-Encoding");
>            if (accepts == NULL) {
>   @@ -369,7 +375,6 @@
>            else {
>                apr_table_mergen(r->headers_out, "Content-Encoding", "gzip");
>            }
>   -        apr_table_setn(r->headers_out, "Vary", "Accept-Encoding");
>            apr_table_unset(r->headers_out, "Content-Length");
>
>            /* initialize deflate output buffer */
>
>
>
>


Mime
View raw message