httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traw...@apache.org
Subject cvs commit: httpd-2.0/modules/generators mod_cgid.c
Date Thu, 31 Oct 2002 09:30:44 GMT
trawick     2002/10/31 01:30:43

  Modified:    modules/generators mod_cgid.c
  Log:
  add a comment lamenting the lack of a cleanup for the CGI child
  process and mentioning some issues related to the problem
  
  Revision  Changes    Path
  1.142     +15 -0     httpd-2.0/modules/generators/mod_cgid.c
  
  Index: mod_cgid.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/generators/mod_cgid.c,v
  retrieving revision 1.141
  retrieving revision 1.142
  diff -u -r1.141 -r1.142
  --- mod_cgid.c	3 Oct 2002 18:15:34 -0000	1.141
  +++ mod_cgid.c	31 Oct 2002 09:30:43 -0000	1.142
  @@ -658,6 +658,21 @@
                                 apr_filename_of_pathname(r->filename));
               }
           }
  +        /* SNAFU: no call to apr_pool_note_subprocess() to cause the
  +         *        CGI to be cleaned up when the request ends (in case
  +         *        client drops connection)...  can't write the pid back
  +         *        to cgid_handler() because by the time we know the pid
  +         *        the new CGI is already started and potentially writing
  +         *        headers and body back to the handler...
  +         *        perhaps cgid_handler() needs to provide a key with
  +         *        a request to which cgid daemon will associate the
  +         *        CGI pid...  at request_rec cleanup time, that key
  +         *        gets sent back to cgid_handler() telling it to kill
  +         *        whatever pid is associated with the key...
  +         *        2 flows per request, which isn't cool...  but 
  +         *        having the CGI running after client killed connection
  +         *        isn't cool either...
  +         */
       } 
       return -1; 
   } 
  
  
  

Mime
View raw message