Return-Path: Delivered-To: apmail-httpd-cvs-archive@httpd.apache.org Received: (qmail 51770 invoked by uid 500); 2 May 2002 13:28:48 -0000 Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list cvs@httpd.apache.org Received: (qmail 51750 invoked by uid 500); 2 May 2002 13:28:47 -0000 Delivered-To: apmail-apache-1.3-cvs@apache.org Date: 2 May 2002 13:28:46 -0000 Message-ID: <20020502132846.68086.qmail@icarus.apache.org> From: jim@apache.org To: apache-1.3-cvs@apache.org Subject: cvs commit: apache-1.3/src/os/unix os.c X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N jim 02/05/02 06:28:46 Modified: src/os/unix os.c Log: OK. This is admittedly anal. But the whole idea behind cpp macros is to avoid things like "we know NSLINKMODULE_OPTION_NONE is 0" and making such shortcuts as this. This makes it clear what exactly we are setting, and though admittedly verbose, the tradeoff of a few bytes of source is worth it :) Revision Changes Path 1.25 +4 -2 apache-1.3/src/os/unix/os.c Index: os.c =================================================================== RCS file: /home/cvs/apache-1.3/src/os/unix/os.c,v retrieving revision 1.24 retrieving revision 1.25 diff -u -r1.24 -r1.25 --- os.c 1 May 2002 22:51:20 -0000 1.24 +++ os.c 2 May 2002 13:28:46 -0000 1.25 @@ -111,8 +111,10 @@ if (NSCreateObjectFileImageFromFile(path, &image) != NSObjectFileImageSuccess) return NULL; -#if defined(NSLINKMODULE_OPTION_RETURN_ON_ERROR) - handle = NSLinkModule(image, path, NSLINKMODULE_OPTION_RETURN_ON_ERROR); +#if defined(NSLINKMODULE_OPTION_RETURN_ON_ERROR) && defined(NSLINKMODULE_OPTION_NONE) + handle = NSLinkModule(image, path, + NSLINKMODULE_OPTION_RETURN_ON_ERROR | + NSLINKMODULE_OPTION_NONE); #else handle = NSLinkModule(image, path, FALSE); #endif