httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jwool...@apache.org
Subject cvs commit: httpd-2.0/modules/ssl ssl_engine_pphrase.c
Date Thu, 30 May 2002 22:39:08 GMT
jwoolley    02/05/30 15:39:08

  Modified:    modules/ssl ssl_engine_pphrase.c
  Log:
  This definitely gets the award for least useful error message of the month.
  
  Not only should it just say "can't do that on win32," which is after all
  the bottom line, it was spitting out openssl error messages which were
  totally useless.  Eg:
  
  [30/May/2002 17:31:17 05760] [error] Init: PassPhraseDialog BuiltIn not
  supported in server private key from file
  F:/Apache/Apache2/conf/ssl/secure.key (OpenSSL library error follows)
  [30/May/2002 17:31:17 05760] [error] OpenSSL: error:0D084069:asn1
  encoding routines:d2i_ASN1_SET:bad tag
  [30/May/2002 17:31:17 05760] [error] OpenSSL: error:0D09D082:asn1
  encoding routines:d2i_RSAPrivateKey:parsing
  [30/May/2002 17:31:17 05760] [error] OpenSSL: error:0D09B00D:asn1
  encoding routines:d2i_PrivateKey:ASN1 lib
  
  Which is essentially saying "OpenSSL couldn't read your private key because
  it was encrypted, and we can't get the passphrase the way you asked us to
  on this platform."
  
  Brought to my attention by the inquiry of:  Chris Hsiang <chsiang@ivivos.com>
  
  Revision  Changes    Path
  1.41      +3 -4      httpd-2.0/modules/ssl/ssl_engine_pphrase.c
  
  Index: ssl_engine_pphrase.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/ssl/ssl_engine_pphrase.c,v
  retrieving revision 1.40
  retrieving revision 1.41
  diff -u -d -u -r1.40 -r1.41
  --- ssl_engine_pphrase.c	17 May 2002 11:24:17 -0000	1.40
  +++ ssl_engine_pphrase.c	30 May 2002 22:39:08 -0000	1.41
  @@ -418,10 +418,9 @@
   #ifdef WIN32
                   if (sc->server->pphrase_dialog_type == SSL_PPTYPE_BUILTIN) {
                       ap_log_error(APLOG_MARK, APLOG_ERR, 0, s,
  -                                 "Init: PassPhraseDialog BuiltIn not "
  -                                 "supported in server private key from file "
  -                                 "%s", szPath);
  -                    ssl_log_ssl_error(APLOG_MARK, APLOG_ERR, s);
  +                                 "Init: SSLPassPhraseDialog builtin is not "
  +                                 "supported on Win32 (key file "
  +                                 "%s)", szPath);
                       ssl_die();
                   }
   #endif /* WIN32 */
  
  
  

Mime
View raw message