httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jwool...@apache.org
Subject cvs commit: httpd-2.0/modules/experimental cache_hash.c cache_hash.h
Date Mon, 06 May 2002 01:10:24 GMT
jwoolley    02/05/05 18:10:24

  Modified:    modules/experimental cache_hash.c cache_hash.h
  Log:
  grr... mod_mem_cache didn't take kindly to that constness fix.  So I'm
  reverting it and will just have to live with the warning for now.  FirstBill,
  what's The Right Way to fix this?  Should we drop all the const qualifiers
  in there, or should cache_hash_set() return a const void * and mod_mem_cache
  should cast away the const, or what?
  
  Revision  Changes    Path
  1.3       +4 -4      httpd-2.0/modules/experimental/cache_hash.c
  
  Index: cache_hash.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/experimental/cache_hash.c,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -d -u -r1.2 -r1.3
  --- cache_hash.c	6 May 2002 00:58:47 -0000	1.2
  +++ cache_hash.c	6 May 2002 01:10:24 -0000	1.3
  @@ -285,10 +285,10 @@
   	return NULL;
   }
   
  -CACHE_DECLARE(const void *) cache_hash_set(cache_hash_t *ht,
  -                                           const void *key,
  -                                           apr_ssize_t klen,
  -                                           const void *val)
  +CACHE_DECLARE(void *) cache_hash_set(cache_hash_t *ht,
  +                                     const void *key,
  +                                     apr_ssize_t klen,
  +                                     const void *val)
   {
       cache_hash_entry_t **hep, *tmp;
       const void *tval;
  
  
  
  1.4       +2 -2      httpd-2.0/modules/experimental/cache_hash.h
  
  Index: cache_hash.h
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/experimental/cache_hash.h,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -d -u -r1.3 -r1.4
  --- cache_hash.h	6 May 2002 00:58:47 -0000	1.3
  +++ cache_hash.h	6 May 2002 01:10:24 -0000	1.4
  @@ -115,8 +115,8 @@
    * @remark If the value is NULL the hash entry is deleted.
    * @return The value of the deleted cache entry (so the caller can clean it up).
    */
  -CACHE_DECLARE(const void *) cache_hash_set(cache_hash_t *ht, const void *key,
  -                                           apr_ssize_t klen, const void *val);
  +CACHE_DECLARE(void *) cache_hash_set(cache_hash_t *ht, const void *key,
  +                                     apr_ssize_t klen, const void *val);
   
   /**
    * Look up the value associated with a key in a hash table.
  
  
  

Mime
View raw message