httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From minf...@apache.org
Subject cvs commit: apache-1.3/src/modules/proxy proxy_http.c
Date Sun, 21 Apr 2002 21:16:39 GMT
minfrin     02/04/21 14:16:39

  Modified:    src/modules/proxy proxy_http.c
  Log:
  Add a FIXME note around some broken code. The write is writing a buffer
  of bogus data with a length that was never initialised.
  
  Revision  Changes    Path
  1.98      +7 -2      apache-1.3/src/modules/proxy/proxy_http.c
  
  Index: proxy_http.c
  ===================================================================
  RCS file: /home/cvs/apache-1.3/src/modules/proxy/proxy_http.c,v
  retrieving revision 1.97
  retrieving revision 1.98
  diff -u -r1.97 -r1.98
  --- proxy_http.c	21 Apr 2002 11:35:07 -0000	1.97
  +++ proxy_http.c	21 Apr 2002 21:16:39 -0000	1.98
  @@ -152,7 +152,7 @@
       const char *strp;
       char *strp2;
       const char *err, *desthost;
  -    int i, j, sock, len, backasswards;
  +    int i, j, sock,/* len,*/ backasswards;
       table *req_hdrs, *resp_hdrs;
       array_header *reqhdrs_arr;
       table_entry *reqhdrs_elts;
  @@ -579,6 +579,11 @@
        * Is it an HTTP/0.9 respose? If so, send the extra data we read from
        * upstream as the start of the reponse to client
        */
  +/* FIXME: This code is broken: we try and write a buffer and length that
  + * were never intelligently initialised. Rather have a bit of broken protocol
  + * handling for now than broken code.
  + */
  +/*
       if (backasswards) {
           ap_hard_timeout("proxy send assbackward", r);
   
  @@ -590,7 +595,7 @@
           }
           ap_kill_timeout(r);
       }
  -
  +*/
   
   #ifdef CHARSET_EBCDIC
       /*
  
  
  

Mime
View raw message