Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Sender: trawick@rdu88-250-166.nc.rr.com
To: dev@httpd.apache.org
Cc: httpd-2.0-cvs@apache.org
Subject: Re: cvs commit: httpd-2.0/server listen.c
References: <20020320070308.47932.qmail@icarus.apache.org>
From: Jeff Trawick <trawick@attglobal.net>
Date: 20 Mar 2002 05:47:48 -0500
In-Reply-To: <20020320070308.47932.qmail@icarus.apache.org>
Message-ID: <m3663r7bxn.fsf@rdu88-250-166.nc.rr.com>
Lines: 28
User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

wrowe@apache.org writes:

> wrowe       02/03/19 23:03:07
> 
>   Modified:    server   listen.c
>   Log:
>     Here's the patch that really sucks.  old_listeners points to an array
>     of apr_socket objects already destroyed by their cleanups, and in any
>     case they now live in invalid memory.  Extend their lifetimes.
>   
>     This implies that the process pool grows on every restart for no good
>     reason.  One possible solution is to let the old pconf survive until
>     the new pconf is alive.  Another is to create the listeners in a subpool
>     of process->pool, destroyed after the old_listeners are closed.
>   
>     Either which way, a better solution exists, but this closes the immediate
>     bug.  [How haven't we been segfaulting in unix on restarts before this
>     patch, gurus?]

good question...  even more interesting (to me) is the question "how
haven't we been segfaulting in unix on restarts even when we build with
electric fence and pool debug, time after time after time" :)

maybe somebody can make us both happy with the answer

-- 
Jeff Trawick | trawick@attglobal.net
Born in Roswell... married an alien...