httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: httpd-2.0/server/mpm/winnt mpm_winnt.c
Date Wed, 20 Mar 2002 14:16:35 GMT
Jeff Trawick <trawick@attglobal.net> writes:

> rbb@apache.org writes:
> 
> > On 20 Mar 2002 wrowe@apache.org wrote:
> > 
> > > wrowe       02/03/19 20:29:55
> > > 
> > >   Modified:    server/mpm/winnt mpm_winnt.c
> > >   Log:
> > >     When restarting [always graceful on Win32], we don't repeat pre_mpm
> > >     (Unix doesn't, we shouldn't either.)  [Ryan Bloom]
> > >    
> > >   -    if ((parent_pid == my_pid) || one_process) {
> > >   +    /* ### If non-graceful restarts are ever introduced - we need to rerun

> > >   +     * the pre_mpm hook on subsequent non-graceful restarts.  But Win32

> > >   +     * has only graceful style restarts - and we need this hook to act 
> > >   +     * the same on Win32 as on Unix.
> > >   +     */
> > >   +    if (!restart && ((parent_pid == my_pid) || one_process)) {
> > >            /* Set up the scoreboard. */
> > >            if (ap_run_pre_mpm(pconf, SB_SHARED) != OK) {
> > >                return 1;
> > 
> > While I agree with this patch, you also need to kill the cleanup on the
> > scoreboard, so that it isn't set to NULL when pconf is cleared.
> 
> Actually, the cleanup never runs because it never finds the data in
> the pconf pool :)  But yes it needs to be dealt with.

wrong... let me restate...  we currently have logic to kill the
cleanup for graceful restart but that call to cleanup_kill is bogus in
that 1) it searches the wrong pool and 2) if OtherBill's changes to
keep using the same scoreboard forever and ever then we don't need to
kill the cleanup anyway

-- 
Jeff Trawick | trawick@attglobal.net
Born in Roswell... married an alien...

Mime
View raw message