Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Reply-To: <rbb@covalent.net>
From: "Ryan Bloom" <rbb@covalent.net>
To: <dev@httpd.apache.org>,
	<httpd-2.0-cvs@apache.org>
Subject: RE: cvs commit: httpd-2.0/server/mpm/worker worker.c
Date: Sun, 27 Jan 2002 12:05:21 -0800
Organization: Covalent Technologies
Message-ID: <003501c1a76d$f3a3b2b0$0a01230a@KOJ>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
In-Reply-To: <20020127125208.27738.qmail@icarus.apache.org>
Importance: Normal

> stoddard    02/01/27 04:52:08
> 
>   Modified:    .        CHANGES
>                include  http_connection.h httpd.h
>                modules/http http_core.c
>                modules/proxy proxy_ftp.c proxy_http.c
>                server   connection.c core.c
>                server/mpm/beos beos.c
>                server/mpm/mpmt_os2 mpmt_os2_child.c
>                server/mpm/netware mpm_netware.c
>                server/mpm/perchild perchild.c
>                server/mpm/prefork prefork.c
>                server/mpm/winnt mpm_winnt.c
>                server/mpm/worker worker.c
>   Log:
>   Remove the create_connection hook and put the client_socket back
into
> the
>   conn_rec. The create_connection_hook has a design flaw that prevents
it
>   from making decisions based on vhost information.

-1.  You can't back out a patch because it doesn't do something it
wasn't designed to do!  That hook was meant to allow different filters
to be added based on the connection used, not based on the
configuration.  If you want to do something based on the configuration,
you have to wait until the request has been read.  Removing the socket
from the conn_rec has all sorts of advantages, not the least being that
it keeps people from using the socket without going through filters.

Ryan