httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brad Nicholes" <BNICHO...@novell.com>
Subject Re: cvs commit: httpd-2.0/modules/mappers mod_negotiation.c
Date Tue, 29 Jan 2002 16:13:54 GMT
   I asked this question yesterday but I didn't get a reply.  I don't
know if you are still working on this problem or if this is a different
issue, but as it stands, mod_negotiation doesn't do anything.    The
reason is because a check for "dirent.filetype != APR_REG" was added but
APR_FINFO_TYPE was not requested in the call to apr_dir_read().  The
only information that was asked for in the call to apr_dir_read() is
APR_FINFO_DIRENT which appears to be equivalent to APR_FINFO_NAME. 
Since APR_FINFO_TYPE was not asked for, the check for "dirent.filetype
!= APR_REG" will always be true and no files will be negotiated.  If
APR_FINFO_TYPE is added, then stat() will be called for every file which
will be extremely expensive.  Can the check for "dirent.filetype !=
APR_REG" be removed? 

thanks,
Brad

>>> gregames@apache.org Monday, January 28, 2002 2:18:10 PM >>>
gregames    02/01/28 13:18:10

  Modified:    modules/mappers mod_negotiation.c
  Log:
  backing out fix for missing path info and query string.  wrowe beat
me to
  it.
  
  Revision  Changes    Path
  1.93      +0 -4      httpd-2.0/modules/mappers/mod_negotiation.c
  
  Index: mod_negotiation.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/mappers/mod_negotiation.c,v
  retrieving revision 1.92
  retrieving revision 1.93
  diff -u -r1.92 -r1.93
  --- mod_negotiation.c	28 Jan 2002 18:43:19 -0000	1.92
  +++ mod_negotiation.c	28 Jan 2002 21:18:10 -0000	1.93
  @@ -2892,10 +2892,6 @@
           }
       }
   
  -    /* preserve path info and query string from the original request
*/
  -    sub_req->path_info = r->path_info;
  -    sub_req->args = r->args;
  -    
       /* now do a "fast redirect" ... promotes the sub_req into the
main req */
       ap_internal_fast_redirect(sub_req, r);
   
  
  
  

Mime
View raw message