httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: httpd-2.0/server core.c
Date Wed, 30 Jan 2002 01:59:50 GMT
stoddard@apache.org writes:

> stoddard    02/01/29 17:57:53
> 
>   Modified:    server   core.c
>   Log:
>   Now how did this slip by. Fixes a segfault. I tested this code, really...

I'm not sure this is the only one.

var decls:

    core_net_rec *net = f->ctx;
    core_ctx_t *ctx = net->in_ctx;

The first time through f->ctx is NULL, so net->in_ctx is a
segfault.  Right?

>   Index: core.c
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/server/core.c,v
>   retrieving revision 1.140
>   retrieving revision 1.141
>   diff -u -r1.140 -r1.141
>   --- core.c	29 Jan 2002 19:02:03 -0000	1.140
>   +++ core.c	30 Jan 2002 01:57:53 -0000	1.141
>   @@ -3209,7 +3209,7 @@
>        core_output_filter_ctx_t *ctx = net->out_ctx;
>    
>        if (ctx == NULL) {
>   -        ctx = apr_pcalloc(net->c->pool, sizeof(*ctx));
>   +        ctx = apr_pcalloc(c->pool, sizeof(*ctx));
>            net->out_ctx = ctx;
>        }

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message