httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@covalent.net>
Subject Re: cvs commit: httpd-2.0/server main.c core.c
Date Tue, 08 Jan 2002 17:33:57 GMT
From: <dreid@apache.org>
Sent: Tuesday, January 08, 2002 10:30 AM


>   1.127     +2 -1      httpd-2.0/server/core.c
>   
>   Index: core.c
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/server/core.c,v
>   retrieving revision 1.126
>   retrieving revision 1.127
>   diff -u -r1.126 -r1.127
>   --- core.c 2 Jan 2002 07:56:25 -0000 1.126
>   +++ core.c 8 Jan 2002 16:30:16 -0000 1.127
>   @@ -3361,7 +3361,8 @@
>    
>    static int core_open_logs(apr_pool_t *pconf, apr_pool_t *plog, apr_pool_t *ptemp,
server_rec *s)
>    {
>   -    ap_open_logs(s, pconf);
>   +    apr_pool_clear(plog);
>   +    ap_open_logs(s, plog);
>        return OK;  
>    }

If anyone really objects to this change, it seems like ap_open_logs could accept
both pconf, and plog.  But plog is required to assure they have the correct lifetime,
and the 'pconf only' pool was a bug, IMHO.


Mime
View raw message