httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brad Nicholes" <BNICHO...@novell.com>
Subject Re: cvs commit: httpd-2.0/server/mpm/netware mpm_netware.c
Date Tue, 18 Dec 2001 16:16:29 GMT
Jeff,
     I think that the mistake I made here was not changing the error
message text.  I had changed HARD_SERVER_LIMIT to HARD_THREAD_LIMIT on
purpose because NetWare does not have processes.  Therefore we will
never have more than one server anyway and in fact the NetWare MPM does
not even provide a way for the user to change MAX_SERVERS because it
doesn't make sense for us.  Is there any reason why you changed this to
HARD_SERVER_LIMIT other than it didn't seem to make sense with the
message text?  If not, I will go ahead and change it back with the
appropriate message text.

thanks,
Brad

>>> trawick@apache.org Tuesday, December 18, 2001 7:18:28 AM >>>
trawick     01/12/18 06:18:28

  Modified:    server/mpm/netware mpm_netware.c
  Log:
  fix some references to the wrong constant (HARD_SERVER_LIMIT vs.
  HARD_THREAD_LIMIT)
  
  Revision  Changes    Path
  1.17      +3 -3      httpd-2.0/server/mpm/netware/mpm_netware.c
  
  Index: mpm_netware.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/server/mpm/netware/mpm_netware.c,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- mpm_netware.c	2001/12/18 13:48:53	1.16
  +++ mpm_netware.c	2001/12/18 14:18:28	1.17
  @@ -1131,12 +1131,12 @@
       if (ap_threads_limit > HARD_THREAD_LIMIT) {
          ap_log_error(APLOG_MARK, APLOG_STARTUP | APLOG_NOERRNO, 0,
NULL, 
                       "WARNING: MaxClients of %d exceeds compile time
limit "
  -                    "of %d servers,", ap_threads_limit,
HARD_SERVER_LIMIT);
  +                    "of %d servers,", ap_threads_limit,
HARD_THREAD_LIMIT);
          ap_log_error(APLOG_MARK, APLOG_STARTUP | APLOG_NOERRNO, 0,
NULL, 
                       " lowering MaxClients to %d.  To increase,
please "
  -                    "see the", HARD_SERVER_LIMIT);
  +                    "see the", HARD_THREAD_LIMIT);
          ap_log_error(APLOG_MARK, APLOG_STARTUP | APLOG_NOERRNO, 0,
NULL,
  -                    " HARD_SERVER_LIMIT define in %s.",
  +                    " HARD_THREAD_LIMIT define in %s.",
                       AP_MPM_HARD_LIMITS_FILE);
          ap_threads_limit = HARD_THREAD_LIMIT;
       } 
  
  
  

Mime
View raw message