httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: httpd-2.0 STATUS
Date Mon, 24 Dec 2001 20:43:42 GMT
Ryan Bloom <rbb@covalent.net> writes:

> >   +
> >   +    * ap_create_scoreboard() can exit the process, leaving stuff like
> >   +      mod_cgid's daemon process stranded.  Either ap_create_scoreboard()
> >   +      needs to be called at a different time or the pre-mpm hook needs
> >   +      to be able to return an error code.
> 
> The real problem here is that it is calling exit() directly.

the above assumes that ap_create_scoreboard() will no longer call
exit()...  sorry if that was unclear

>                                                That is almost always
> incorrect.  There are cleanup programs that need to be run.  If the calls to exit
> are replaced with calls to destroy_and_exit_process, this problem should
> go away.  Of course, that means that the destroy_and_exit_process will need
> to become non-static.

I would much prefer allowing the pre-mpm hook to signal an error
rather than introducing another API function.  Alternatively, the MPM
could set an error indicator and return an error when it hits
ap_mpm_run().  But that is a little messy too.

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message