httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aa...@apache.org
Subject cvs commit: httpd-2.0 CHANGES
Date Wed, 12 Dec 2001 23:56:46 GMT
aaron       01/12/12 15:56:46

  Modified:    server   mpm_common.c
               .        CHANGES
  Log:
  Fix a bug in how we select the IP for the POD to connect to for dummy
  connects (dislodging a doomed child from the accept mutex). No longer
  do we assume that the child is listening to 127.0.0.1, but instead
  we just pick the first hostname/port from the listen rec.
  
  Revision  Changes    Path
  1.75      +2 -1      httpd-2.0/server/mpm_common.c
  
  Index: mpm_common.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/server/mpm_common.c,v
  retrieving revision 1.74
  retrieving revision 1.75
  diff -u -r1.74 -r1.75
  --- mpm_common.c	2001/12/10 20:10:05	1.74
  +++ mpm_common.c	2001/12/12 23:56:46	1.75
  @@ -372,7 +372,8 @@
       apr_file_pipe_timeout_set((*pod)->pod_in, 0);
       (*pod)->p = p;
       
  -    apr_sockaddr_info_get(&(*pod)->sa, "127.0.0.1", APR_UNSPEC, ap_listeners->bind_addr->port,
0, p);
  +    apr_sockaddr_info_get(&(*pod)->sa, ap_listeners->bind_addr->hostname,
  +                          APR_UNSPEC, ap_listeners->bind_addr->port, 0, p);
   
       return APR_SUCCESS;
   }
  
  
  
  1.474     +8 -0      httpd-2.0/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/CHANGES,v
  retrieving revision 1.473
  retrieving revision 1.474
  diff -u -r1.473 -r1.474
  --- CHANGES	2001/12/10 20:17:35	1.473
  +++ CHANGES	2001/12/12 23:56:46	1.474
  @@ -1,5 +1,13 @@
   Changes with Apache 2.0.30-dev
   
  +  *) The POD no longer assumes the child is listening on 127.0.0.1
  +     and now pulls the first hostname in the list of listeners to
  +     perform the dummy connect on. This fixes a bug when the user
  +     had configured the Listen directive for an IP other than
  +     127.0.0.1. This would result in undead children and error
  +     messages such as "Connection refused: connect to listener".
  +     [Aaron Bannert]
  +
     *) The worker MPM now respects the LockFile setting, needed to
        avoid locking problems with NFS.  [Jeff Trawick]
   
  
  
  

Mime
View raw message