Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Content-Type: text/plain;
  charset="iso-8859-1"
From: Ryan Bloom <rbb@covalent.net>
Reply-To: rbb@covalent.net
Organization: Covalent Technologies
To: dev@httpd.apache.org, brianp@apache.org, httpd-2.0-cvs@apache.org
Subject: Re: cvs commit: httpd-2.0/server core.c
Date: Mon, 26 Nov 2001 06:38:09 -0800
References: <20011126084929.21057.qmail@icarus.apache.org>
In-Reply-To: <20011126084929.21057.qmail@icarus.apache.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-Id: <20011126143810.31F9146E02@koj.rkbloom.net>

On Monday 26 November 2001 12:49 am, brianp@apache.org wrote:
> brianp      01/11/26 00:49:29
>
>   Modified:    server   core.c
>   Log:
>   Another fix for the core_output_filter() code that concatenates
>   small buckets: It's possible for the temporary brigade to
>   contain more than one bucket.  If this happens, we need to
>   recover the buckets after the first from the temporary brigade
>   before destroying it.

That shouldn't be possible. The whole point of this loop is that the
data in the brigade is < the max size of one bucket. If we have created
two buckets in the temp brigade either our values are off, or there is
another bug.  Can you post the example that caused this bug? IMHO,
this is the wrong fix.

Ryan
______________________________________________________________
Ryan Bloom				rbb@apache.org
Covalent Technologies			rbb@covalent.net
--------------------------------------------------------------