Return-Path: Delivered-To: apmail-httpd-cvs-archive@httpd.apache.org Received: (qmail 721 invoked by uid 500); 10 Sep 2001 03:55:09 -0000 Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list cvs@httpd.apache.org Received: (qmail 699 invoked by uid 500); 10 Sep 2001 03:55:08 -0000 Delivered-To: apmail-httpd-2.0-cvs@apache.org Date: 10 Sep 2001 03:51:28 -0000 Message-ID: <20010910035128.79291.qmail@icarus.apache.org> From: wrowe@apache.org To: httpd-2.0-cvs@apache.org Subject: cvs commit: httpd-2.0/modules/arch/win32 mod_isapi.c X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N wrowe 01/09/09 20:51:28 Modified: modules/arch/win32 mod_isapi.c Log: There is no errno using apr. A quick grep reveals a dozen or so files with serious errno problems, particularly in mod_dav :( Revision Changes Path 1.50 +4 -4 httpd-2.0/modules/arch/win32/mod_isapi.c Index: mod_isapi.c =================================================================== RCS file: /home/cvs/httpd-2.0/modules/arch/win32/mod_isapi.c,v retrieving revision 1.49 retrieving revision 1.50 diff -u -r1.49 -r1.50 --- mod_isapi.c 2001/08/23 21:17:38 1.49 +++ mod_isapi.c 2001/09/10 03:51:28 1.50 @@ -1239,14 +1239,14 @@ char *fspec; fspec = ap_server_root_relative(cmd->pool, filename); - if (apr_stat(&tmp, fspec, - APR_FINFO_TYPE, cmd->temp_pool) != APR_SUCCESS) { - ap_log_error(APLOG_MARK, APLOG_WARNING, errno, cmd->server, + if ((rv = apr_stat(&tmp, fspec, + APR_FINFO_TYPE, cmd->temp_pool)) != APR_SUCCESS) { + ap_log_error(APLOG_MARK, APLOG_WARNING, rv, cmd->server, "ISAPI: unable to stat(%s), skipping", filename); return NULL; } if (tmp.filetype != APR_REG) { - ap_log_error(APLOG_MARK, APLOG_WARNING, errno, cmd->server, + ap_log_error(APLOG_MARK, APLOG_WARNING|APLOG_NOERRNO, 0, cmd->server, "ISAPI: %s isn't a regular file, skipping", filename); return NULL; }