Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Date: 31 Aug 2001 22:07:05 -0000
Message-ID: <20010831220705.66347.qmail@icarus.apache.org>
From: wrowe@apache.org
To: httpd-2.0-cvs@apache.org
Subject: cvs commit: httpd-2.0/server request.c
Status: O

wrowe       01/08/31 15:07:05

  Modified:    server   request.c
  Log:
    Add some notes of things I noticed while proofing.  We still need a
    resolution to rnew->chunked = r->chunked in subrequests!
  
  Revision  Changes    Path
  1.44      +7 -5      httpd-2.0/server/request.c
  
  Index: request.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/server/request.c,v
  retrieving revision 1.43
  retrieving revision 1.44
  diff -u -r1.43 -r1.44
  --- request.c	2001/08/31 10:58:47	1.43
  +++ request.c	2001/08/31 22:07:05	1.44
  @@ -1366,8 +1366,6 @@
   } 
   
   
  -
  -
   AP_DECLARE(request_rec *) ap_sub_req_method_uri(const char *method,
                                                   const char *new_file,
                                                   const request_rec *r,
  @@ -1382,7 +1380,7 @@
   
       rnew->per_dir_config = r->server->lookup_defaults;
   
  -    /* We have to run this after ap_set_sub_req_protocol, or the r->main
  +    /* We have to run this after fill_in_sub_req_vars, or the r->main
        * pointer won't be setup
        */
       ap_run_create_request(rnew);
  @@ -1427,7 +1425,7 @@
   
       rnew->chunked        = r->chunked;
   
  -    /* We have to run this after ap_set_sub_req_protocol, or the r->main
  +    /* We have to run this after fill_in_sub_req_vars, or the r->main
        * pointer won't be setup
        */
       ap_run_create_request(rnew);
  @@ -1540,9 +1538,13 @@
       rnew = make_sub_request(r);
       fill_in_sub_req_vars(rnew, r, next_filter);
   
  +    /* XXX Either this is needed for all subreq types (move into
  +     * fill_in_sub_req_vars), or it isn't needed at all.  
  +     * WHICH IS IT?
  +     */
       rnew->chunked        = r->chunked;
   
  -    /* We have to run this after ap_set_sub_req_protocol, or the r->main
  +    /* We have to run this after fill_in_sub_req_vars, or the r->main
        * pointer won't be setup
        */
       ap_run_create_request(rnew);