httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Bloom <...@covalent.net>
Subject Re: cvs commit: httpd-2.0/modules/metadata mod_expires.c
Date Fri, 10 Aug 2001 05:32:09 GMT
On Thursday 09 August 2001 22:29, rbb@apache.org wrote:
> rbb         01/08/09 22:29:09
>
>   Modified:    .        CHANGES
>                modules/metadata mod_expires.c
>   Log:
>   Fix a bug in mod_expires.  Previous to this patch, if you
>   told mod_expires to add 604800 seconds to the last-modified
>   time, it actually added 604800 usec's to the last-modified time,
>   so that when looking at the response it looked like nothing
>   had been done.  The root of the problem was that we always compute
>   time in usec's, but we ask users to input sec's.  This means we
>   need to convert to usec's before using those values.

BTW, this was caught with the perl-framework test-suite in httpd-test.  So, we will never
hit this
problem in this module again, because we already have a test for this bug.  :-)  The test
was
written by John Sachs.

Ryan
_____________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
Covalent Technologies			rbb@covalent.net
-----------------------------------------------------------------------------

Mime
View raw message