httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ch...@apache.org
Subject cvs commit: httpd-proxy/module-2.0 CHANGES proxy_ftp.c
Date Thu, 28 Jun 2001 10:00:09 GMT
chuck       01/06/28 03:00:09

  Modified:    module-2.0 CHANGES proxy_ftp.c
  Log:
  Some servers send no response to FTP QUIT command and just close the
  connection. Remove result code check for QUIT. We gave them fair
  warning.
  
  Revision  Changes    Path
  1.2       +4 -0      httpd-proxy/module-2.0/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /home/cvs/httpd-proxy/module-2.0/CHANGES,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- CHANGES	2001/06/08 09:59:25	1.1
  +++ CHANGES	2001/06/28 10:00:06	1.2
  @@ -1,6 +1,10 @@
   
   mod_proxy changes for httpd 2.0.18-dev
   
  +  *) Remove result code check for FTP QUIT command. Some servers send
  +     nothing at all back in response to QUIT.
  +     [Chuck Murcko <chuck@topsail.org>]
  +
     *) Reverse previous patch since the core reverted.
        [Chuck Murcko <chuck@topsail.org>]
   
  
  
  
  1.61      +1 -10     httpd-proxy/module-2.0/proxy_ftp.c
  
  Index: proxy_ftp.c
  ===================================================================
  RCS file: /home/cvs/httpd-proxy/module-2.0/proxy_ftp.c,v
  retrieving revision 1.60
  retrieving revision 1.61
  diff -u -r1.60 -r1.61
  --- proxy_ftp.c	2001/06/28 07:04:18	1.60
  +++ proxy_ftp.c	2001/06/28 10:00:07	1.61
  @@ -1637,16 +1637,7 @@
       ap_pass_brigade(origin->output_filters, bb);
       ap_log_error(APLOG_MARK, APLOG_DEBUG|APLOG_NOERRNO, 0, r->server,
                    "proxy: FTP: QUIT");
  -    /* responses: 221, 500 */
  -    /*   221 Service closing control connection. */
  -    /*   500 Syntax error, command unrecognized. */
  -    /* FIXME
  -     * Using ftp_getrc_msg is blocking here (in fact, anywhere after the
  -     * while loop in section VI). Disabling for now, to get things working.
  -     * i = ftp_getrc_msg(origin, cbb, buffer, sizeof(buffer));
  -     * ap_log_error(APLOG_MARK, APLOG_DEBUG|APLOG_NOERRNO, 0, r->server,
  -     *           "proxy: FTP: %d %s", i, buffer);
  -     */
  +
       apr_brigade_destroy(bb);
       return OK;
   }
  
  
  

Mime
View raw message