Mailing-List: contact apache-cvs-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Date: 12 May 2001 13:05:28 -0000
Message-ID: <20010512130528.95966.qmail@apache.org>
From: trawick@apache.org
To: httpd-2.0-cvs@apache.org
Subject: cvs commit: httpd-2.0 configure.in

trawick     01/05/12 06:05:28

  Modified:    .        configure.in
  Log:
  Only turn on AP_DEBUG if we're using gcc.
  
  The AP_DEBUG flavor of the cmd_func declarations is not portable.
  Last night Roy removed the check for gcc before turning on AP_DEBUG.
  Interestingly (or not :) ) the AP_DEBUG flavor of cmd_func compiles
  cleanly on gcc but the non-AP_DEBUG flavor doesn't. The non-AP_DEBUG
  flavor compiles cleanly with Tru64 cc and AIX xlc but the AP_DEBUG
  flavor doesn't. (On Tru64 we get a bunch of warnings with the
  AP_DEBUG flavor but at least it compiles; the same cannot be said of
  AIX xlc.)
  
  Perhaps we should use a symbol other than AP_DEBUG to distinguish
  between the cmd_func flavors.  Then AP_DEBUG can be turned on
  regardless of compiler.  The new flag can be turned on for gcc+
  --enable-maintainer-mode, or perhaps for gcc always since the non-
  AP_DEBUG flavor won't compile cleanly with gcc.  (what a mess; this
  probably wouldn't work right for different levels of gcc anyway)
  
  Revision  Changes    Path
  1.153     +1 -1      httpd-2.0/configure.in
  
  Index: configure.in
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/configure.in,v
  retrieving revision 1.152
  retrieving revision 1.153
  diff -u -r1.152 -r1.153
  --- configure.in	2001/05/12 03:48:30	1.152
  +++ configure.in	2001/05/12 13:05:27	1.153
  @@ -208,7 +208,7 @@
   	[PORT=80])
   
   AC_ARG_ENABLE(maintainer-mode,[  --enable-maintainer-mode  Turn on debugging and compile time warnings],
  -  [APR_ADDTO(CPPFLAGS,-DAP_DEBUG)
  +  [if test "$ac_cv_prog_gcc" = "yes"; then APR_ADDTO(CPPFLAGS,-DAP_DEBUG); fi
   ])dnl
   
   APACHE_ENABLE_LAYOUT