httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <>
Subject Re: cvs commit: httpd-2.0 STATUS
Date Thu, 17 May 2001 21:39:25 GMT

>   +    * There is a big leak of MMAPs that occurs in modules such as
>   +      mod_file_cache that needs to be taken care of.  Several
>   +      potential solutions were tossed about on new-httpd and apr-dev
>   +      in late April/early May.  Perhaps the cleanest proposed
>   +      approaches were the following:
>   +          - dup the cached apr_file_t into the request pool on each
>   +            request so that the MMAP is created in the request pool
>   +          - just cache the FD, not the whole apr_file_t.  Build the apr_file_t
>   +            and its apr_bucket_file in the request pool.
>   +          - add an extra parameter to apr_bucket_file_create() which is the
>   +            pool that an MMAP (if any) for that file should be created in

We don't need to dup the cached file.  Just use apr_os_get_file and
apr_os_put_file to move the file descriptor to the correct pool.  We don't
add a new cleanup, so the file won't be closed, but we will then be using
the correct pool when we create the MMAP.


Ryan Bloom               
406 29th St.
San Francisco, CA 94131

View raw message