httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@covalent.net>
Subject Re: cvs commit: httpd-2.0/server/mpm/threaded threaded.c
Date Wed, 02 May 2001 20:04:06 GMT

>    #include <signal.h>
>   +#include <limits.h>             /* for INT_MAX */
>
>    /*
>     * Actual definitions of config globals
>   @@ -488,7 +489,7 @@
>        /* TODO: Switch to a system where threads reuse the results from earlier
>           poll calls - manoj */
>        while (1) {
>   -        workers_may_exit |= (ap_max_requests_per_child != 0) && (requests_this_child
<= 0);
>   +        workers_may_exit |= (requests_this_child <= 0);
>            if (workers_may_exit) break;
>
>            (void) ap_update_child_status(process_slot, thread_slot, SERVER_READY,
>   @@ -1378,6 +1379,14 @@
>        }
>
>        ap_max_requests_per_child = atoi(arg);
>   +
>   +    /* a value of zero means infinity.  The following removes a conditional
>   +     * from worker_thread's hot path
>   +     */
>   +
>   +    if (!ap_max_requests_per_child) {
>   +        ap_max_requests_per_child = INT_MAX;
>   +    }

I'm missing something.  Doesn't this make MaxRequestsPerChild equal to
INT_MAX, not infinity?  I don't see how this is equivalent to what we used
to do.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message