httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stodd...@apache.org
Subject cvs commit: httpd-2.0/server log.c
Date Thu, 17 May 2001 12:10:26 GMT
stoddard    01/05/17 05:10:26

  Modified:    server   log.c
  Log:
  Fix a segfault in apr_proc_other_child_unregister. Jeff recently made
  a change in APR otherchild.c to unregister all OC registrations as
  part of pool cleanup.  This means that we must NOT explicitly call
  apr_proc_other_child_unregister out of other pool clean-up routines.
  In this case, the OC cleanup was being called first then the piped_log_cleanup
  was being called which called apr_proc_other_child_unregister.
  
  We could fix this by detecting the case when there are no more OCs registered
  in apr_proc_other_child_unregister but that might just mask other problems we
  need to fix anyway.
  
  Revision  Changes    Path
  1.92      +0 -1      httpd-2.0/server/log.c
  
  Index: log.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/server/log.c,v
  retrieving revision 1.91
  retrieving revision 1.92
  diff -u -r1.91 -r1.92
  --- log.c	2001/04/10 23:17:59	1.91
  +++ log.c	2001/05/17 12:10:22	1.92
  @@ -673,7 +673,6 @@
       if (pl->pid != NULL) {
   	apr_proc_kill(pl->pid, SIGTERM);
       }
  -    apr_proc_other_child_unregister(pl);
       apr_file_close(ap_piped_log_read_fd(pl));
       apr_file_close(ap_piped_log_write_fd(pl));
       return APR_SUCCESS;
  
  
  

Mime
View raw message