httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traw...@apache.org
Subject cvs commit: httpd-2.0/modules/generators mod_cgid.c
Date Wed, 16 May 2001 19:20:01 GMT
trawick     01/05/16 12:19:59

  Modified:    .        STATUS
               modules/generators mod_cgid.c
  Log:
  don't destroy the pcgi pool when the other-child registration
  of the cgi daemon goes away... it goes away *because* the
  pcgi pool is being destroyed
  
  Revision  Changes    Path
  1.233     +1 -14     httpd-2.0/STATUS
  
  Index: STATUS
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/STATUS,v
  retrieving revision 1.232
  retrieving revision 1.233
  diff -u -r1.232 -r1.233
  --- STATUS	2001/05/12 03:48:29	1.232
  +++ STATUS	2001/05/16 19:19:47	1.233
  @@ -1,5 +1,5 @@
   APACHE 2.0 STATUS:						-*-text-*-
  -Last modified at [$Date: 2001/05/12 03:48:29 $]
  +Last modified at [$Date: 2001/05/16 19:19:47 $]
   
   Release:
   
  @@ -94,19 +94,6 @@
   RELEASE SHOWSTOPPERS:
   
       WARNING: ALWAYS check srclib/apr/STATUS and srclib/apr-util/STATUS
  -
  -    * threaded + cgid: "apachectl graceful" followed by "apachectl
  -      restart" results in all processes but cgid going away; parent
  -      died referencing other-child registration structures
  -
  -      a couple of solutions/work-arounds for this problem:
  -
  -      1) disable APR_HAS_OTHER_CHILD support
  -      2) teach APR to clean up other-child registrations when the 
  -         associated pool goes away (see 
  -         Message-Id:
  -	 <200104262241.SAA04468@adsl-77-241-65.rdu.bellsouth.net> for
  -	 a patch.
   
       * There is a bug in how we sort some hooks, at least the pre-config
         hook.  The first time we call the hooks, they are in the correct 
  
  
  
  1.86      +3 -1      httpd-2.0/modules/generators/mod_cgid.c
  
  Index: mod_cgid.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/generators/mod_cgid.c,v
  retrieving revision 1.85
  retrieving revision 1.86
  diff -u -r1.85 -r1.86
  --- mod_cgid.c	2001/05/04 18:42:51	1.85
  +++ mod_cgid.c	2001/05/16 19:19:56	1.86
  @@ -242,7 +242,9 @@
               apr_proc_other_child_unregister(data);
               break;
           case APR_OC_REASON_UNREGISTER:
  -            apr_pool_destroy(pcgi);
  +            /* we get here when pcgi is cleaned up; pcgi gets cleaned
  +             * up when pconf gets cleaned up
  +             */
               kill(*sd, SIGHUP);
               break;
       }
  
  
  

Mime
View raw message