httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stodd...@apache.org
Subject cvs commit: httpd-2.0/modules/loggers mod_log_config.c
Date Wed, 16 May 2001 13:49:45 GMT
stoddard    01/05/16 06:49:45

  Modified:    .        CHANGES
               modules/loggers mod_log_config.c
  Log:
  Do not start piped log processes during the config file
  preflight.  This change also circumvents a problem on
  Windows where the rotatelog processes created during preflight
  was not getting cleaned up properly.
  
  Revision  Changes    Path
  1.200     +6 -0      httpd-2.0/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/CHANGES,v
  retrieving revision 1.199
  retrieving revision 1.200
  diff -u -r1.199 -r1.200
  --- CHANGES	2001/05/15 04:25:16	1.199
  +++ CHANGES	2001/05/16 13:49:32	1.200
  @@ -1,4 +1,10 @@
   Changes with Apache 2.0.18-dev
  +  *) Do not start piped log processes during the config file 
  +     preflight.  This change also circumvents a problem on 
  +     Windows where the rotatelog processes created during preflight
  +     was not getting cleaned up properly.
  +     [Bill Stoddard]
  +
     *) add "Request Phase Participation" info to mod_info
        [Doug MacEachern]
   
  
  
  
  1.59      +12 -0     httpd-2.0/modules/loggers/mod_log_config.c
  
  Index: mod_log_config.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/loggers/mod_log_config.c,v
  retrieving revision 1.58
  retrieving revision 1.59
  diff -u -r1.58 -r1.59
  --- mod_log_config.c	2001/05/02 13:37:22	1.58
  +++ mod_log_config.c	2001/05/16 13:49:40	1.59
  @@ -1013,6 +1013,18 @@
                                            apr_array_header_t *default_format)
   {
       apr_status_t status;
  +    void *data;
  +    const char *userdata_key = "open_config_log";
  +
  +    /* Skip opening the log the first time through. It's really
  +     * good to avoid starting the piped log process during preflight.
  +     */
  +    apr_pool_userdata_get(&data, userdata_key, s->process->pool);
  +    if (!data) {
  +        apr_pool_userdata_set((const void *)1, userdata_key,
  +                         apr_pool_cleanup_null, s->process->pool);
  +        return cls;
  +    }
   
       if (cls->log_fd != NULL) {
           return cls;             /* virtual config shared w/main server */
  
  
  

Mime
View raw message