httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From minf...@apache.org
Subject cvs commit: httpd-proxy/module-2.0 proxy_http.c
Date Tue, 10 Apr 2001 20:55:07 GMT
minfrin     01/04/10 13:55:06

  Modified:    module-2.0 proxy_http.c
  Log:
  A client POST request would be read entirely into RAM before sending it
  on the client - a potential DoS. Fixed.
  
  Revision  Changes    Path
  1.54      +4 -6      httpd-proxy/module-2.0/proxy_http.c
  
  Index: proxy_http.c
  ===================================================================
  RCS file: /home/cvs/httpd-proxy/module-2.0/proxy_http.c,v
  retrieving revision 1.53
  retrieving revision 1.54
  diff -u -r1.53 -r1.54
  --- proxy_http.c	2001/04/10 20:44:16	1.53
  +++ proxy_http.c	2001/04/10 20:55:05	1.54
  @@ -558,16 +558,14 @@
       /* send the request data, if any. */
       if (ap_should_client_block(r)) {
   	while ((i = ap_get_client_block(r, buffer, sizeof buffer)) > 0) {
  -/* XXX FIXME: Only sends downstream when request is fully loaded */
               e = apr_bucket_pool_create(buffer, i, p);
               APR_BRIGADE_INSERT_TAIL(bb, e);
  +	    e = apr_bucket_flush_create();
  +	    APR_BRIGADE_INSERT_TAIL(bb, e);
  +	    ap_pass_brigade(origin->output_filters, bb);
  +	    apr_brigade_cleanup(bb);
           }
       }
  -
  -    /* Flush the data to the origin server */
  -    e = apr_bucket_flush_create();
  -    APR_BRIGADE_INSERT_TAIL(bb, e);
  -    ap_pass_brigade(origin->output_filters, bb);
   
   
       /*
  
  
  

Mime
View raw message