httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: httpd-2.0/server/mpm/winnt mpm_winnt.c
Date Tue, 09 Jan 2001 14:46:35 GMT

> >   +    if (strcmp(r->handler, "*.*")) {
> >   +        return DECLINED;
> >   +    }
> >   +
> 
> As extensively discussed, this is _wrong_.

Jon Travis pointed out to me yesterday that this is wrong in more ways
than one.  The problem is that before the change, Apache would run all the
handlers that registered specific handler types, like DIR_MAGIC_TYPE or
server-parsed-html before it ran any handler that registered generic
handler types, ones with *'s in them.

This behavior is now gone, which is a bad thing IMHO.  This means that a
module that matches multiple handler types, only gets one chance to
matche them all.  I didn't think this was important yesterday, but I woke
up this morning, and I believe it is.  Somebody tell me I'm wrong
please.   I just want somebody else to say I am wrong.  :-)

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------




Mime
View raw message