httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: cvs commit: httpd-2.0/server/mpm/prefork prefork.c
Date Sun, 07 Jan 2001 21:08:33 GMT
rbb@covalent.net wrote:
> 
> >    #define ASIS_MAGIC_TYPE "httpd/send-as-is"
> >
> >   -static int asis_handler(request_rec *r)
> >   +static int asis_handler(const char *handler,request_rec *r)
> >    {
> >        apr_file_t *f = NULL;
> >        apr_status_t status;
> >        const char *location;
> >        apr_size_t nbytes;
> >
> >   +    if(strcmp(handler,ASIS_MAGIC_TYPE) && strcmp(handler,"send-as-is"))
> >   +   return DECLINED;
> 
> Can we change the strcmp to a memcmp, since we know that these are static
> strings?

I guess.

> >   @@ -1543,7 +1543,6 @@
> >        static int restart_num = 0;
> >        int no_detach = 0;
> >
> >   -    one_process = !!getenv("ONE_PROCESS");
> >        no_detach = !!getenv("NO_DETACH");
> >
> >        /* sigh, want this only the second time around */
> >   @@ -1578,7 +1577,7 @@
> >    #ifdef AUX3
> >        (void) set42sig();
> >    #endif
> >   -    /* TODO: set one_process properly */ one_process = 0;
> >   +    one_process = !!getenv("ONE_PROCESS");
> 
> Why was this moved?  It worked properly on Linux, and by removing the
> one_process=0, it worked on FreeBSD as well.  Just asking, because we
> probably want to move the no_detach to the same location.  The basically
> do the same thing.

It was probably spurious. I moved it initially because I thought it
might fix a problem. Then I left it there because it fixed a comment.
:-)

BTW, please can we make maintainer-mode have -Wall in it? 

Cheers,

Ben.

--
http://www.apache-ssl.org/ben.html

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff

Mime
View raw message