Return-Path: Delivered-To: apmail-apache-cvs-archive@apache.org Received: (qmail 21592 invoked by uid 500); 1 Dec 2000 17:50:04 -0000 Mailing-List: contact apache-cvs-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list apache-cvs@apache.org Received: (qmail 21548 invoked by uid 500); 1 Dec 2000 17:50:04 -0000 Delivered-To: apmail-apache-2.0-cvs@apache.org Date: Fri, 1 Dec 2000 09:52:06 -0800 (PST) From: rbb@covalent.net X-Sender: rbb@koj.rkbloom.net To: new-httpd@apache.org cc: apache-2.0-cvs@apache.org Subject: Re: cvs commit: apache-2.0/src/modules/mpm/prefork prefork.c In-Reply-To: <20001201174129.10263.qmail@locus.apache.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N On 1 Dec 2000 trawick@locus.apache.org wrote: > trawick 00/12/01 09:41:28 > > Modified: src/modules/mpm/prefork prefork.c > Log: > If apr_lock() or apr_unlock() fail, write a log message before bailing > out. Woah. You just took a debug only check, and turned it into a run-time check that happens every time. I'm not saying this is bad, but it should be noted in the log. :-) +1 for the change, just wanted a clearer log message someplace. Ryan _______________________________________________________________________________ Ryan Bloom rbb@apache.org 406 29th St. San Francisco, CA 94131 -------------------------------------------------------------------------------