httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject Re: cvs commit: httpd-2.0/modules/generators mod_cgid.c
Date Sat, 23 Dec 2000 07:20:34 GMT

>   Get mod_cgid to use apr calls for creating the actual CGI process.
>   This also allows mod_cgid to use ap_os_create_priviledged_process,
>   thus allowing for SuExec execution from mod_cgid.  Currently, we do
>   not support everything that standard SuExec supports, but at least
>   it works minimally now.

Okay, so all the SuExec changes started happening tonight when I realized
that I couldn't setup without SuExec, and I wanted a test setup
on my box exactly like so I could find the problems we have
been having.  In trying to get the test box setup, I found some other
interesting problems.  #1, SuExec is useless if you can't configure it
when running ./configure, because it is so particular about things.  I
have added those features.  #2, SuExec wasn't working with mod_cgid.  This
patch should solve that problem.

As a part of this patch, I took a good chunk of code that used to be in
mod_cgi, and copied it to mod_cgid.  This is good and bad.  It is good,
because it got rid of some ugly code in mod_cgid, but it is bad, because
we have duplicate code now.  At some point, it would be great if somebody
could try to merge these two modules.

The one feature that is missing from mod_cgid with regard to SuExec, is
the r->notes table.  We check that table for a note from mod_userdir.  We
don't currently copy that table from the child to the cgid process.  All
we really need to do is copy that one field, since we know what it is.  I
got lazy, and just wanted to get something working before I called it
quits for the night.


Ryan Bloom               
406 29th St.
San Francisco, CA 94131

View raw message